From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754953AbeDMOMh (ORCPT ); Fri, 13 Apr 2018 10:12:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:56628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754229AbeDMOMg (ORCPT ); Fri, 13 Apr 2018 10:12:36 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 366F02077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 13 Apr 2018 10:12:33 -0400 From: Steven Rostedt To: Petr Mladek Cc: Sergey Senozhatsky , akpm@linux-foundation.org, linux-mm@kvack.org, Peter Zijlstra , Jan Kara , Tetsuo Handa , Sergey Senozhatsky , Tejun Heo , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: Ratelimit messages printed by console drivers Message-ID: <20180413101233.0792ebf0@gandalf.local.home> In-Reply-To: <20180413124704.19335-1-pmladek@suse.com> References: <20180413124704.19335-1-pmladek@suse.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Apr 2018 14:47:04 +0200 Petr Mladek wrote: > The interval is set to one hour. It is rather arbitrary selected time. > It is supposed to be a compromise between never print these messages, > do not lockup the machine, do not fill the entire buffer too quickly, > and get information if something changes over time. I think an hour is incredibly long. We only allow 100 lines per hour for printks happening inside another printk? I think 5 minutes (at most) would probably be plenty. One minute may be good enough. -- Steve