From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH v3 03/14] net/mlx5: support L3 VXLAN flow
Date: Fri, 13 Apr 2018 14:13:39 +0200
Message-ID: <20180413121339.6hzso326hp4udc5f@laranjeiro-vm.dev.6wind.com>
References: <20180410133415.189905-1-xuemingl%40mellanox.com>
 <20180413112023.106420-4-xuemingl@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Shahaf Shuler <shahafs@mellanox.com>, dev@dpdk.org
To: Xueming Li <xuemingl@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id DCA811BBC2
 for <dev@dpdk.org>; Fri, 13 Apr 2018 14:13:15 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id r82so3843439wme.0
 for <dev@dpdk.org>; Fri, 13 Apr 2018 05:13:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180413112023.106420-4-xuemingl@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Apr 13, 2018 at 07:20:12PM +0800, Xueming Li wrote:
> This patch support L3 VXLAN, no inner L2 header comparing to standard
> VXLAN protocol. L3 VXLAN using specific overlay UDP destination port to
> discriminate against standard VXLAN, FW has to be configured to support
> it:
>   sudo mlxconfig -d <device> -y s IP_OVER_VXLAN_EN=1
>   sudo mlxconfig -d <device> -y s IP_OVER_VXLAN_PORT=<port>

This fully deserves to update MLX5 guide with such information, users
are already not reading it, don't expect them to read commit logs.

> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 2aae988f2..644f26a95 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -413,7 +413,9 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
>  		.dst_sz = sizeof(struct ibv_flow_spec_tunnel),
>  	},
>  	[RTE_FLOW_ITEM_TYPE_VXLAN] = {
> -		.items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH),
> +		.items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
> +			       RTE_FLOW_ITEM_TYPE_IPV4, /* L3 VXLAN. */
> +			       RTE_FLOW_ITEM_TYPE_IPV6), /* L3 VXLAN. */

s/L3/For L3/

>  		.actions = valid_actions,
>  		.mask = &(const struct rte_flow_item_vxlan){
>  			.vni = "\xff\xff\xff",
> -- 
> 2.13.3

There is an important question about this support as the firmware needs
to be configured for it.

1. Is such rule accepted by the kernel modules if the support is not
enabled in the firmware?

2. Is it possible from the PMD to query such information?

If both answers are no, such features should be enabled through a device
parameter to let the PMD refuse such un-supported flow request.

Thanks,

-- 
Nélio Laranjeiro
6WIND