All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ioan Nicu <ioan.nicu.ext@nokia.com>
Cc: Alexandre Bounine <alex.bou9@gmail.com>,
	Barry Wood <barry.wood@idt.com>,
	Matt Porter <mporter@kernel.crashing.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Logan Gunthorpe <logang@deltatee.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
	Frank Kunz <frank.kunz@nokia.com>,
	Alexander Sverdlin <alexander.sverdlin@nokia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rapidio: fix rio_dma_transfer error handling
Date: Fri, 13 Apr 2018 14:16:34 -0700	[thread overview]
Message-ID: <20180413141634.4935b2da32aa4705b9181ffd@linux-foundation.org> (raw)
In-Reply-To: <20180413070917.GA2794@nokia.com>

On Fri, 13 Apr 2018 09:09:18 +0200 Ioan Nicu <ioan.nicu.ext@nokia.com> wrote:

> > > And please remember to always include all information regarding
> > > end-user impact when fixing bugs.
> > > 
> > This bug fix is applicable to versions starting from v4.6
> 
> Actually, this is something I broke with my previous patch where I added a
> kref to the mport_dma_req structure. Before this patch, all the error paths
> were doing kfree(req) instead of kref_put(&req->refcount, dma_req_free).
> 
> Now that dma_req_free() is called, it dereferences req->dmach, which is
> initialized late in do_dma_request(), so dma_req_free() could be called
> with a NULL req->dmach in some cases.
> 
> Sorry if I did not make this clear enough in the description.

I added

Fixes: bbd876adb8c72 ("rapidio: use a reference count for struct mport_dma_req")

(correct?) and removed cc:stable.

      reply	other threads:[~2018-04-13 21:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 15:06 [PATCH] rapidio: fix rio_dma_transfer error handling Ioan Nicu
2018-04-12 15:08 ` Alexander Sverdlin
2018-04-12 18:47 ` Alexandre Bounine
2018-04-12 21:28 ` Andrew Morton
2018-04-12 23:44   ` Alexandre Bounine
2018-04-13  7:09     ` Ioan Nicu
2018-04-13 21:16       ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180413141634.4935b2da32aa4705b9181ffd@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alex.bou9@gmail.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=barry.wood@idt.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=frank.kunz@nokia.com \
    --cc=ioan.nicu.ext@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=mporter@kernel.crashing.org \
    --cc=tvrtko.ursulin@intel.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.