All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
	Souptick Joarder <jrdr.linux@gmail.com>,
	darrick.wong@oracle.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fs: xfs: Change return type to vm_fault_t
Date: Sun, 15 Apr 2018 05:34:27 -0700	[thread overview]
Message-ID: <20180415123427.GA11379@bombadil.infradead.org> (raw)
In-Reply-To: <20180415120426.GA10479@infradead.org>

On Sun, Apr 15, 2018 at 05:04:26AM -0700, Christoph Hellwig wrote:
> On Sun, Apr 15, 2018 at 04:11:04AM -0700, Matthew Wilcox wrote:
> > > Please just send one damn patch adding the typedef and the sparse
> > > annotation and converting everyone over.  Splitting this into five
> > > gazillion patches that do nothing doesn't help anyone.
> > 
> > The XFS one is trivial.  Many of the others are not.
> 
> if they arne't trivial you are doing something wrong.  That is you
> fix bugs that exist independent of the annotation together with the
> annotation.
> 
> Fix all the bugs first, and send them in (including for -stable) and
> then do the annotations in one big patch.

They aren't all bugs.  Some of them are just splitting errnos apart
from return values for typesafety.  The ones that are bugfixes are
unlikely-to-happen bugs like running out of memory when allocating a
page table, and returning "we inserted the PTE" instead of "we ran out
of memory".  More of a QOI issue than an exploitable bug.

  reply	other threads:[~2018-04-15 12:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14 20:05 [PATCH] fs: xfs: Change return type to vm_fault_t Souptick Joarder
2018-04-14 21:59 ` Dave Chinner
2018-04-14 22:24   ` Matthew Wilcox
2018-04-15  7:21     ` Christoph Hellwig
2018-04-15 11:11       ` Matthew Wilcox
2018-04-15 12:04         ` Christoph Hellwig
2018-04-15 12:34           ` Matthew Wilcox [this message]
2018-04-16  8:57             ` Christoph Hellwig
2018-04-16 11:14               ` Matthew Wilcox
2018-04-16 11:23                 ` Christoph Hellwig
2018-04-16 11:31                   ` Matthew Wilcox
2018-04-16 17:03                     ` Darrick J. Wong
2018-05-30 12:35                       ` Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180415123427.GA11379@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.