From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from gofer.mess.org ([88.97.38.141]:54065 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbeDPJPa (ORCPT ); Mon, 16 Apr 2018 05:15:30 -0400 Date: Mon, 16 Apr 2018 10:15:28 +0100 From: Sean Young To: Greg KH Cc: linux-media@vger.kernel.org, Warren Sturm , Mauro Carvalho Chehab , Andy Walls , stable@vger.kernel.org Subject: Re: [PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting Message-ID: <20180416091527.ryx7vdekzjwcrpxo@gofer.mess.org> References: <2bd4184fbea37ecdfcb0a334c6bef45786feb486.1523785117.git.sean@mess.org> <20180416075228.GB2121@kroah.com> <20180416084344.k4e3tx4jd5lswfh3@gofer.mess.org> <20180416085015.GA2598@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180416085015.GA2598@kroah.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, Apr 16, 2018 at 10:50:15AM +0200, Greg KH wrote: > On Mon, Apr 16, 2018 at 09:43:45AM +0100, Sean Young wrote: > > On Mon, Apr 16, 2018 at 09:52:28AM +0200, Greg KH wrote: > > > What is the git commit id of this patch, and the other patches in this > > > series and the 4.14 patch series that you sent out? > > > > lirc_zilog was dropped in v4.16, so this can't be patched upstream. > > Ah you are right, should we just ditch them here as well as they > obviously do not work? :) > > > > Please read: > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > for how to do this in a way that I can pick them up. > > > > These patches have been tested with different types of hardware. Is there > > anything else I can do to get these patches included? > > When submitting patches to stable, you need to be explicit as to why > they are needed, and if they are not upstream, why not. > > In this case, for obviously broken code that is not used anymore (as > it is gone in 4.16), why don't we just take the patch that removed the > driver to the stable trees as well? Well in v4.16 the ir-kbd-i2c.c driver can do what the lirc_zilog does in v4.15 (and earlier), so it wasn't ditched as such. It's a case of replaced by mainline. Since I was getting bug reports on it, there must be users of the lirc_zilog driver. That being said, the old lirc_dev and lirc_zilog is pretty awful code. Sean