All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: zyw@rock-chips.com, zhangqing@rock-chips.com, xsf@rock-chips.com,
	tony.xie@rock-chips.com, w.egorov@phytec.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions
Date: Mon, 16 Apr 2018 10:38:21 +0100	[thread overview]
Message-ID: <20180416093821.sqrcc6mmnc23njul@dell> (raw)
In-Reply-To: <1522335000-23057-1-git-send-email-d.schultz@phytec.de>

On Thu, 29 Mar 2018, Daniel Schultz wrote:

> Since all three shutdown functions have almost the same code, all logic
> from the shutdown functions can be refactored to a new function
> "rk808_update_bits", which can update a register by a given address and
> bitmask.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
> Changes:
> 	v2: Re-submit with recipients from Rockchip.
> 	v3: - Added devicetree property to enable the PMIC reset seperate from 
> 	      "rockchip,system-power-controller".
> 	    - Dropped the first patch of this serie.
> 	v4: Splitted refactoring and the new reset feature.
> 	v5: Removed null pointer from rk808_update_bits.
> 
>  drivers/mfd/rk808.c | 46 +++++++++++++---------------------------------
>  1 file changed, 13 insertions(+), 33 deletions(-)

I'd still like an Ack/Review from the Rockchip guys please.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2018-04-16  9:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 14:49 [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions Daniel Schultz
2018-03-29 14:50 ` [PATCH v5 2/2] mfd: rk808: Add restart functionality Daniel Schultz
2018-04-16  9:38   ` Lee Jones
2018-04-16  9:38 ` Lee Jones [this message]
2018-07-24  9:39   ` [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions Wadim Egorov
2018-07-24  9:39     ` Wadim Egorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416093821.sqrcc6mmnc23njul@dell \
    --to=lee.jones@linaro.org \
    --cc=d.schultz@phytec.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.xie@rock-chips.com \
    --cc=w.egorov@phytec.de \
    --cc=xsf@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.