From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fan Zhang Subject: [PATCH] examples/ip_pipeline: fix uninitialized scalar variable Date: Mon, 16 Apr 2018 11:47:51 +0100 Message-ID: <20180416104751.65646-1-roy.fan.zhang@intel.com> Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com To: dev@dpdk.org Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 169E21B16C for ; Mon, 16 Apr 2018 12:55:25 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 272575 Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object") Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 2 +- examples/ip_pipeline/link.c | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index 199a31ff8..ec43a2308 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -133,7 +133,7 @@ cmd_link(char **tokens, char *out, size_t out_size) { - struct link_params p; + struct link_params p = {0}; struct link_params_rss rss; struct link *link; char *name; diff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c index 26ff41ba9..25717808c 100644 --- a/examples/ip_pipeline/link.c +++ b/examples/ip_pipeline/link.c @@ -121,17 +121,19 @@ link_create(const char *name, struct link_params *params) (params->tx.queue_size == 0)) return NULL; - port_id = params->port_id; if (params->dev_name) { status = rte_eth_dev_get_port_by_name(params->dev_name, &port_id); if (status) return NULL; - } else - if (!rte_eth_dev_is_valid_port(port_id)) + } else { + if (!rte_eth_dev_is_valid_port(params->port_id)) return NULL; + port_id = params->port_id; + } + rte_eth_dev_info_get(port_id, &port_info); mempool = mempool_find(params->rx.mempool_name); -- 2.13.6