From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbeDPQHd (ORCPT ); Mon, 16 Apr 2018 12:07:33 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33280 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753025AbeDPQHc (ORCPT ); Mon, 16 Apr 2018 12:07:32 -0400 Date: Mon, 16 Apr 2018 11:07:30 -0500 From: Kim Phillips To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Subject: Re: [PATCH] perf tools: set kernel end address properly Message-Id: <20180416110730.1dd12801e43be66ea5d0cc48@arm.com> In-Reply-To: <20180416135125.GA23802@kernel.org> References: <20180416042240.21528-1-namhyung@kernel.org> <20180416092345.GA23274@krava> <20180416135125.GA23802@kernel.org> Organization: Arm X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Apr 2018 10:51:25 -0300 Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 16, 2018 at 11:23:45AM +0200, Jiri Olsa escreveu: > > On Mon, Apr 16, 2018 at 01:22:40PM +0900, Namhyung Kim wrote: > > > The map_groups__fixup_end() was called to set end addresses of kernel > > > map and module maps. But now machine__create_modules() is set the end > > > address of modules properly so the only remaining piece is the kernel > > > map. We can set it with adjacent module's address directly instead of > > > calling the map_groups__fixup_end(). If there's no module after the > > > kernel map, the end address will be ~0ULL. > > I wonder if it wouldn't be better to have it as last symbol + PAGE_SIZE > or something like that... > > But, anyway, Kim, does this fix things for you? Can I have your > Tested-by? No, perf test 1 still fails: vmlinux symtab matches kallsyms: FAILED! Kim