From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f82cC-0000MN-BZ for mharc-grub-devel@gnu.org; Mon, 16 Apr 2018 07:48:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f82c9-0000JL-7e for grub-devel@gnu.org; Mon, 16 Apr 2018 07:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f82c4-00087b-03 for grub-devel@gnu.org; Mon, 16 Apr 2018 07:48:04 -0400 Received: from boksu.net-space.pl ([185.15.1.105]:48246) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.71) (envelope-from ) id 1f82c3-00084t-KW for grub-devel@gnu.org; Mon, 16 Apr 2018 07:47:59 -0400 Received: (from localhost user: 'dkiper' uid#4000 fake: STDIN (dkiper@boksu.net-space.pl)) by router-fw-old.local.net-space.pl id S1836257AbeDPLrw (ORCPT ); Mon, 16 Apr 2018 13:47:52 +0200 Date: Mon, 16 Apr 2018 13:47:52 +0200 From: Daniel Kiper To: nvinson234@gmail.com Cc: dkiper@net-space.pl, grub-devel@gnu.org Subject: Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files Message-ID: <20180416114752.GA21283@router-fw-old.local.net-space.pl> References: <215c48d12d36aec6c8c2c48a4be325fc743d764c.1523131110.git.nvinson234@gmail.com> <20180410205228.GB25917@router-fw-old.local.net-space.pl> <25902d38-4c37-9c9a-19b0-aeda756c8613@gmail.com> <20180411083138.GB2642@router-fw-old.local.net-space.pl> <5e568894-74eb-1fa8-b518-256fd1ba79af@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e568894-74eb-1fa8-b518-256fd1ba79af@gmail.com> User-Agent: Mutt/1.3.28i X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.15.1.105 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 11:48:06 -0000 On Wed, Apr 11, 2018 at 07:45:01AM -0700, Nick Vinson wrote: > On 04/11/2018 01:31 AM, Daniel Kiper wrote: > > On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: > >> On 04/10/2018 01:52 PM, Daniel Kiper wrote: > >>> On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: > >>>> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > >>>> partuuid target. Update grub.texi documentation. The following table > >>>> shows how GRUB_DISABLE_LINUX_UUID, GRUB_DISABLE_LINUX_PARTUUID, and > >>>> initramfs detection interact: > >>>> > >>>> Initramfs GRUB_DISABLE_LINUX_PARTUUID GRUB_DISABLE_LINUX_UUID Linux Root > >>>> detected Set Set ID Method > >>>> > >>>> False False False part UUID > >>>> False False True part UUID > >>>> False True False dev name > >>>> False True True dev name > >>>> True False False fs UUID > >>>> True False True part UUID > >>>> True True False fs UUID > >>>> True True True dev name > >>> > >>> What will happen if GRUB_DISABLE_LINUX_PARTUUID and/or GRUB_DISABLE_LINUX_UUID > >>> are not set? I think that you can avoid that by setting defaults. You do that > >>> for GRUB_DISABLE_LINUX_PARTUUID in next patch but GRUB_DISABLE_LINUX_UUID > >>> does not have any default. > >>> > >> > >> If they're not set, then that's the same as them being set to 'False'. > >> I should have worded my table above a bit differently and used Yes/No > >> instead of True/False as that is really what it is trying to convey. > > > > IMO it will be more confusing. I think that I would use lowercase > > false/true as it is used in the script and below the table I would > > add a note that == false or something like that. > > Ack. I will update the commit comment. Thanks. May I ask you to put similar table into docs/grub.texi? Daniel