From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2 02/10] spi: Expose spi_{map,unmap}_buf() for internal use Date: Mon, 16 Apr 2018 13:11:27 +0100 Message-ID: <20180416121127.GC20726@sirena.org.uk> References: <20180410224439.9260-1-boris.brezillon@bootlin.com> <20180410224439.9260-3-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4397939641288136125==" Cc: Yogesh Gaur , Vignesh R , Kamal Dasu , Richard Weinberger , Miquel Raynal , linux-spi@vger.kernel.org, Peter Pan , Marek Vasut , Frieder Schrempf , linux-mtd@lists.infradead.org, Cyrille Pitchen , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Maxime Chevallier , Sourav Poddar , Brian Norris , David Woodhouse To: Boris Brezillon Return-path: In-Reply-To: <20180410224439.9260-3-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org --===============4397939641288136125== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DSayHWYpDlRfCAAQ" Content-Disposition: inline --DSayHWYpDlRfCAAQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 11, 2018 at 12:44:31AM +0200, Boris Brezillon wrote: > 2/ we create a new header (drivers/spi/internals.h?) for all > definitions that are meant for internal use (shared between spi.c > and spi-mem.c) > I personally prefer #2 as it provides a better separation between spi > and spi-mem code. > --- > drivers/spi/spi.c | 23 +++++------------------ > include/linux/spi/spi.h | 26 ++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 18 deletions(-) I prefer that too (if you prefer it you should go with it so it's the option on the table!). I'd go with drivers/spi/internals.h though so that it's even more obvious if something is being silly trying to use it when they shouldn't. --DSayHWYpDlRfCAAQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlrUku4ACgkQJNaLcl1U h9CJ5wgAgpUXA9I2SZRq2krUOla6ygDObJY6loIIg/CrJLASzhi6JC/ZqI3me5mR OMrmmZXyLTN5Ri7SZaBvivDbBJ3D4JnguhE9Smz4kw9EGfE75K64mcA2iVMIZ9aj cudXzuTFUXUWLJ/MEUIA5L9ZTyi2nthn8srO2Ef2GPLBwtbYeqwqJnmXrJBhDK3Z jAKS3p3PZgeDzHGEArpxTj64eVbtr07NixAQXu1eNq5udVWYTqpA0Fj+udghxWAk +c8fOrLqZspda8EpKktwgHOTyFJOnVhX+9pgid8nfkVWTUce1aUe5iC0ILJSZ77N nNuHPLUYuiXroKwyC464boDxIyBzmg== =Utjc -----END PGP SIGNATURE----- --DSayHWYpDlRfCAAQ-- --===============4397939641288136125== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============4397939641288136125==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from heliosphere.sirena.org.uk ([2a01:7e01::f03c:91ff:fed4:a3b6]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f82zE-0008F3-8n for linux-mtd@lists.infradead.org; Mon, 16 Apr 2018 12:12:03 +0000 Date: Mon, 16 Apr 2018 13:11:27 +0100 From: Mark Brown To: Boris Brezillon Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org, Miquel Raynal , linux-spi@vger.kernel.org, Peter Pan , Frieder Schrempf , Vignesh R , Yogesh Gaur , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kamal Dasu , Sourav Poddar , Maxime Chevallier Subject: Re: [PATCH v2 02/10] spi: Expose spi_{map,unmap}_buf() for internal use Message-ID: <20180416121127.GC20726@sirena.org.uk> References: <20180410224439.9260-1-boris.brezillon@bootlin.com> <20180410224439.9260-3-boris.brezillon@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DSayHWYpDlRfCAAQ" Content-Disposition: inline In-Reply-To: <20180410224439.9260-3-boris.brezillon@bootlin.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --DSayHWYpDlRfCAAQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 11, 2018 at 12:44:31AM +0200, Boris Brezillon wrote: > 2/ we create a new header (drivers/spi/internals.h?) for all > definitions that are meant for internal use (shared between spi.c > and spi-mem.c) > I personally prefer #2 as it provides a better separation between spi > and spi-mem code. > --- > drivers/spi/spi.c | 23 +++++------------------ > include/linux/spi/spi.h | 26 ++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 18 deletions(-) I prefer that too (if you prefer it you should go with it so it's the option on the table!). I'd go with drivers/spi/internals.h though so that it's even more obvious if something is being silly trying to use it when they shouldn't. --DSayHWYpDlRfCAAQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlrUku4ACgkQJNaLcl1U h9CJ5wgAgpUXA9I2SZRq2krUOla6ygDObJY6loIIg/CrJLASzhi6JC/ZqI3me5mR OMrmmZXyLTN5Ri7SZaBvivDbBJ3D4JnguhE9Smz4kw9EGfE75K64mcA2iVMIZ9aj cudXzuTFUXUWLJ/MEUIA5L9ZTyi2nthn8srO2Ef2GPLBwtbYeqwqJnmXrJBhDK3Z jAKS3p3PZgeDzHGEArpxTj64eVbtr07NixAQXu1eNq5udVWYTqpA0Fj+udghxWAk +c8fOrLqZspda8EpKktwgHOTyFJOnVhX+9pgid8nfkVWTUce1aUe5iC0ILJSZ77N nNuHPLUYuiXroKwyC464boDxIyBzmg== =Utjc -----END PGP SIGNATURE----- --DSayHWYpDlRfCAAQ--