All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: songxiaowei <songxiaowei@hisilicon.com>
Cc: Loic Poulain <loic.poulain@linaro.org>,
	Wangbinghui <wangbinghui@hisilicon.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Guodong Xu <guodong.xu@linaro.org>
Subject: Re: 答复: [PATCH] PCI: kirin: Fix reset gpio name
Date: Mon, 16 Apr 2018 14:48:30 +0100	[thread overview]
Message-ID: <20180416134830.GA32565@red-moon> (raw)
In-Reply-To: <99B4C6BADD9E3241B25E52B02BA737C54126803E@DGGEMA505-MBS.china.huawei.com>

On Mon, Apr 16, 2018 at 11:48:52AM +0000, songxiaowei wrote:
> It's a bug indeed, thank you very much for the patch. I think the
> patch is ok.

Is this an ACK ? Please provide one if you want me to merge this
fix.

Lorenzo

> -----邮件原件-----
> 发件人: Loic Poulain [mailto:loic.poulain@linaro.org] 
> 发送时间: 2018年4月16日 19:35
> 收件人: songxiaowei <songxiaowei@hisilicon.com>; Wangbinghui <wangbinghui@hisilicon.com>
> 抄送: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>; lorenzo.pieralisi@arm.com; Loic Poulain <loic.poulain@linaro.org>; Guodong Xu <guodong.xu@linaro.org>
> 主题: Re: [PATCH] PCI: kirin: Fix reset gpio name
> 
> Hi Xiaowei,
> 
> On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@linaro.org> wrote:
> > As documented in the device-tree bindings (pci/kirin-pcie.txt) and 
> > defined in existing device-tree (hi3660.dtsi), the reset gpio name is 
> > 'reset-gpios'. However, driver looks for a 'reset-gpio' resource which 
> > makes the driver probe fail. Fix this.
> >
> > Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe 
> > controller driver")
> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> 
> 
> Are you still maintaining this driver ? Binghui's email seems to be invalid now.
> 
> Regards,
> Loic

  reply	other threads:[~2018-04-16 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  9:19 [PATCH] PCI: kirin: Fix reset gpio name Loic Poulain
2018-04-16 11:34 ` Loic Poulain
2018-04-16 11:48   ` 答复: " songxiaowei
2018-04-16 13:48     ` Lorenzo Pieralisi [this message]
2018-04-17  1:05       ` 答复: " songxiaowei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416134830.GA32565@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bhelgaas@google.com \
    --cc=guodong.xu@linaro.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=songxiaowei@hisilicon.com \
    --cc=wangbinghui@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.