Re: [igt-dev] [PATCH i-g-t 0/3] Enable kms_color tests for amdgpu devices

[Arkadiusz Hiler <arkadiusz.hiler@intel.com>]

On Mon, Apr 16, 2018 at 09:42:37AM -0400, Harry Wentland wrote:
> On 2018-04-13 06:12 PM, Arkadiusz Hiler wrote:
> > On Thu, Apr 12, 2018 at 05:37:23PM -0400, sunpeng.li@amd.com wrote:
> >> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>
> >>
> >> The kms_color tests has some assumptions that are not compatible with
> >> AMD hardware. These patches make it more generic.
> >>
> >> Leo (Sunpeng) Li (3):
> >>   tests/kms_color: Fill entire frame when painting rectangles
> >>   tests/kms_color: Do not mask LUT for non i915 drivers.
> >>   tests/kms_color: Enable color tests for AMDGPU
> >>
> >>  tests/kms_color.c | 28 +++++++++++++++++++++++++---
> >>  1 file changed, 25 insertions(+), 3 deletions(-)
> > 
> > The whole series is
> > Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > 
> > It was my assumption that much of the kms tests can be enabled on
> > non-Intel hardware with just a little bit of work. It's good to see that
> > someone is taking an effort.
> > 
> > Are you planning on enabling more of the test? I guess we have quite a
> > lot of superfluous igt_require_gem() calls scattered around, that should
> > be easy to get rid of.
> > 
> 
> Over time, yes. We have quite limited resources to spend on IGT but would love to do more.

I understand. This is awesome nonetheless.

> > Thanks for the patches, I've just pushed them :-)
> > 
> 
> Thanks for pushing. I think I might have commit rights but didn't want
> to rush pushing them without giving someone else a chance to review.

Sorry for not adding your r-b. I think the mails was stuck in the
moderation queue. Are you subscribed to this new-ish mailing list?

- Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev