From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbeDPRZv (ORCPT ); Mon, 16 Apr 2018 13:25:51 -0400 Received: from anholt.net ([50.246.234.109]:55176 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbeDPRZt (ORCPT ); Mon, 16 Apr 2018 13:25:49 -0400 From: Eric Anholt To: dri-devel@lists.freedesktop.org, Rob Herring , Mark Rutland , Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Stefan Wahren , linux-rpi-kernel@lists.infradead.org Cc: Eric Anholt Subject: [PATCH v2 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node. Date: Mon, 16 Apr 2018 10:25:46 -0700 Message-Id: <20180416172546.32118-1-eric@anholt.net> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180413175632.oz62n363g6rxdp6z@rob-hp-laptop> References: <20180413175632.oz62n363g6rxdp6z@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The GPU subsystem node was a workaround to have a central device to bind V3D and display to. Following the lead of 246774d17fc0 ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove the subsystem node usage and just create a platform device for the DRM device to attach to if any of the subsystem devices are present. v2: Simplify the DT walking code. Signed-off-by: Eric Anholt --- .../bindings/display/brcm,bcm-vc4.txt | 7 ----- drivers/gpu/drm/vc4/vc4_drv.c | 29 ++++++++++++++----- drivers/gpu/drm/vc4/vc4_hvs.c | 1 + drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 4 files changed, 23 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt index 284e2b14cfbe..5fd4717101d6 100644 --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt @@ -4,9 +4,6 @@ The VC4 device present on the Raspberry Pi includes a display system with HDMI output and the HVS (Hardware Video Scaler) for compositing display planes. -Required properties for VC4: -- compatible: Should be "brcm,bcm2835-vc4" or "brcm,cygnus-vc4" - Required properties for Pixel Valve: - compatible: Should be one of "brcm,bcm2835-pixelvalve0", "brcm,bcm2835-pixelvalve1", or "brcm,bcm2835-pixelvalve2" @@ -153,10 +150,6 @@ v3d: v3d@7ec00000 { interrupts = <1 10>; }; -vc4: gpu { - compatible = "brcm,bcm2835-vc4"; -}; - panel: panel { compatible = "ontat,yx700wv03", "simple-panel"; diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 7c95ed5c5cac..13b840b534b8 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -364,22 +364,30 @@ static int vc4_platform_drm_remove(struct platform_device *pdev) return 0; } -static const struct of_device_id vc4_of_match[] = { - { .compatible = "brcm,bcm2835-vc4", }, - { .compatible = "brcm,cygnus-vc4", }, - {}, -}; -MODULE_DEVICE_TABLE(of, vc4_of_match); - static struct platform_driver vc4_platform_driver = { .probe = vc4_platform_drm_probe, .remove = vc4_platform_drm_remove, .driver = { .name = "vc4-drm", - .of_match_table = vc4_of_match, }, }; +static bool +driver_of_table_has_a_match(const struct platform_driver *driver) +{ + struct device_node *node; + + node = of_find_matching_node_and_match(NULL, + driver->driver.of_match_table, + NULL); + if (of_device_is_available(node)) { + of_node_put(node); + return true; + } + + return false; +} + static int __init vc4_drm_register(void) { int ret; @@ -389,6 +397,11 @@ static int __init vc4_drm_register(void) if (ret) return ret; + if (driver_of_table_has_a_match(&vc4_v3d_driver) || + driver_of_table_has_a_match(&vc4_hvs_driver)) { + platform_device_register_simple("vc4-drm", -1, NULL, 0); + } + return platform_driver_register(&vc4_platform_driver); } diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c index 2b62fc5b8d85..730813ee74ae 100644 --- a/drivers/gpu/drm/vc4/vc4_hvs.c +++ b/drivers/gpu/drm/vc4/vc4_hvs.c @@ -262,6 +262,7 @@ static const struct of_device_id vc4_hvs_dt_match[] = { { .compatible = "brcm,bcm2835-hvs" }, {} }; +MODULE_DEVICE_TABLE(of, vc4_hvs_dt_match); struct platform_driver vc4_hvs_driver = { .probe = vc4_hvs_dev_probe, diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index bfc2fa73d2ae..e77e9ebbab4b 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -459,6 +459,7 @@ static const struct of_device_id vc4_v3d_dt_match[] = { { .compatible = "brcm,vc4-v3d" }, {} }; +MODULE_DEVICE_TABLE(of, vc4_v3d_dt_match); struct platform_driver vc4_v3d_driver = { .probe = vc4_v3d_dev_probe, -- 2.17.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: [PATCH v2 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node. Date: Mon, 16 Apr 2018 10:25:46 -0700 Message-ID: <20180416172546.32118-1-eric@anholt.net> References: <20180413175632.oz62n363g6rxdp6z@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180413175632.oz62n363g6rxdp6z@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, Rob Herring , Mark Rutland , Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Stefan Wahren , linux-rpi-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org VGhlIEdQVSBzdWJzeXN0ZW0gbm9kZSB3YXMgYSB3b3JrYXJvdW5kIHRvIGhhdmUgYSBjZW50cmFs IGRldmljZSB0bwpiaW5kIFYzRCBhbmQgZGlzcGxheSB0by4gIEZvbGxvd2luZyB0aGUgbGVhZCBv ZiAyNDY3NzRkMTdmYzAKKCJkcm0vZXRuYXZpdjogcmVtb3ZlIHRoZSBuZWVkIGZvciBhIGdwdS1z dWJzeXN0ZW0gRFQgbm9kZSIpLCByZW1vdmUKdGhlIHN1YnN5c3RlbSBub2RlIHVzYWdlIGFuZCBq dXN0IGNyZWF0ZSBhIHBsYXRmb3JtIGRldmljZSBmb3IgdGhlIERSTQpkZXZpY2UgdG8gYXR0YWNo IHRvIGlmIGFueSBvZiB0aGUgc3Vic3lzdGVtIGRldmljZXMgYXJlIHByZXNlbnQuCgp2MjogU2lt cGxpZnkgdGhlIERUIHdhbGtpbmcgY29kZS4KClNpZ25lZC1vZmYtYnk6IEVyaWMgQW5ob2x0IDxl cmljQGFuaG9sdC5uZXQ+Ci0tLQogLi4uL2JpbmRpbmdzL2Rpc3BsYXkvYnJjbSxiY20tdmM0LnR4 dCAgICAgICAgIHwgIDcgLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5jICAgICAg ICAgICAgICAgICB8IDI5ICsrKysrKysrKysrKysrLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS92YzQv dmM0X2h2cy5jICAgICAgICAgICAgICAgICB8ICAxICsKIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0 X3YzZC5jICAgICAgICAgICAgICAgICB8ICAxICsKIDQgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0 aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJjbSxiY20tdmM0LnR4dCBiL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyY20sYmNtLXZjNC50eHQKaW5kZXggMjg0ZTJi MTRjZmJlLi41ZmQ0NzE3MTAxZDYgMTAwNjQ0Ci0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L2JyY20sYmNtLXZjNC50eHQKKysrIGIvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJjbSxiY20tdmM0LnR4dApAQCAtNCw5ICs0LDYg QEAgVGhlIFZDNCBkZXZpY2UgcHJlc2VudCBvbiB0aGUgUmFzcGJlcnJ5IFBpIGluY2x1ZGVzIGEg ZGlzcGxheSBzeXN0ZW0KIHdpdGggSERNSSBvdXRwdXQgYW5kIHRoZSBIVlMgKEhhcmR3YXJlIFZp ZGVvIFNjYWxlcikgZm9yIGNvbXBvc2l0aW5nCiBkaXNwbGF5IHBsYW5lcy4KIAotUmVxdWlyZWQg cHJvcGVydGllcyBmb3IgVkM0OgotLSBjb21wYXRpYmxlOglTaG91bGQgYmUgImJyY20sYmNtMjgz NS12YzQiIG9yICJicmNtLGN5Z251cy12YzQiCi0KIFJlcXVpcmVkIHByb3BlcnRpZXMgZm9yIFBp eGVsIFZhbHZlOgogLSBjb21wYXRpYmxlOglTaG91bGQgYmUgb25lIG9mICJicmNtLGJjbTI4MzUt cGl4ZWx2YWx2ZTAiLAogCQkgICJicmNtLGJjbTI4MzUtcGl4ZWx2YWx2ZTEiLCBvciAiYnJjbSxi Y20yODM1LXBpeGVsdmFsdmUyIgpAQCAtMTUzLDEwICsxNTAsNiBAQCB2M2Q6IHYzZEA3ZWMwMDAw MCB7CiAJaW50ZXJydXB0cyA9IDwxIDEwPjsKIH07CiAKLXZjNDogZ3B1IHsKLQljb21wYXRpYmxl ID0gImJyY20sYmNtMjgzNS12YzQiOwotfTsKLQogcGFuZWw6IHBhbmVsIHsKIAljb21wYXRpYmxl ID0gIm9udGF0LHl4NzAwd3YwMyIsICJzaW1wbGUtcGFuZWwiOwogCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5j CmluZGV4IDdjOTVlZDVjNWNhYy4uMTNiODQwYjUzNGI4IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dw dS9kcm0vdmM0L3ZjNF9kcnYuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuYwpA QCAtMzY0LDIyICszNjQsMzAgQEAgc3RhdGljIGludCB2YzRfcGxhdGZvcm1fZHJtX3JlbW92ZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCXJldHVybiAwOwogfQogCi1zdGF0aWMgY29u c3Qgc3RydWN0IG9mX2RldmljZV9pZCB2YzRfb2ZfbWF0Y2hbXSA9IHsKLQl7IC5jb21wYXRpYmxl ID0gImJyY20sYmNtMjgzNS12YzQiLCB9LAotCXsgLmNvbXBhdGlibGUgPSAiYnJjbSxjeWdudXMt dmM0IiwgfSwKLQl7fSwKLX07Ci1NT0RVTEVfREVWSUNFX1RBQkxFKG9mLCB2YzRfb2ZfbWF0Y2gp OwotCiBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciB2YzRfcGxhdGZvcm1fZHJpdmVyID0g ewogCS5wcm9iZQkJPSB2YzRfcGxhdGZvcm1fZHJtX3Byb2JlLAogCS5yZW1vdmUJCT0gdmM0X3Bs YXRmb3JtX2RybV9yZW1vdmUsCiAJLmRyaXZlcgkJPSB7CiAJCS5uYW1lCT0gInZjNC1kcm0iLAot CQkub2ZfbWF0Y2hfdGFibGUgPSB2YzRfb2ZfbWF0Y2gsCiAJfSwKIH07CiAKK3N0YXRpYyBib29s Citkcml2ZXJfb2ZfdGFibGVfaGFzX2FfbWF0Y2goY29uc3Qgc3RydWN0IHBsYXRmb3JtX2RyaXZl ciAqZHJpdmVyKQoreworCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZTsKKworCW5vZGUgPSBvZl9m aW5kX21hdGNoaW5nX25vZGVfYW5kX21hdGNoKE5VTEwsCisJCQkJCSAgICAgICBkcml2ZXItPmRy aXZlci5vZl9tYXRjaF90YWJsZSwKKwkJCQkJICAgICAgIE5VTEwpOworCWlmIChvZl9kZXZpY2Vf aXNfYXZhaWxhYmxlKG5vZGUpKSB7CisJCW9mX25vZGVfcHV0KG5vZGUpOworCQlyZXR1cm4gdHJ1 ZTsKKwl9CisKKwlyZXR1cm4gZmFsc2U7Cit9CisKIHN0YXRpYyBpbnQgX19pbml0IHZjNF9kcm1f cmVnaXN0ZXIodm9pZCkKIHsKIAlpbnQgcmV0OwpAQCAtMzg5LDYgKzM5NywxMSBAQCBzdGF0aWMg aW50IF9faW5pdCB2YzRfZHJtX3JlZ2lzdGVyKHZvaWQpCiAJaWYgKHJldCkKIAkJcmV0dXJuIHJl dDsKIAorCWlmIChkcml2ZXJfb2ZfdGFibGVfaGFzX2FfbWF0Y2goJnZjNF92M2RfZHJpdmVyKSB8 fAorCSAgICBkcml2ZXJfb2ZfdGFibGVfaGFzX2FfbWF0Y2goJnZjNF9odnNfZHJpdmVyKSkgewor CQlwbGF0Zm9ybV9kZXZpY2VfcmVnaXN0ZXJfc2ltcGxlKCJ2YzQtZHJtIiwgLTEsIE5VTEwsIDAp OworCX0KKwogCXJldHVybiBwbGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXIoJnZjNF9wbGF0Zm9ybV9k cml2ZXIpOwogfQogCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9odnMuYyBi L2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2h2cy5jCmluZGV4IDJiNjJmYzViOGQ4NS4uNzMwODEz ZWU3NGFlIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9odnMuYworKysgYi9k cml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9odnMuYwpAQCAtMjYyLDYgKzI2Miw3IEBAIHN0YXRpYyBj b25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHZjNF9odnNfZHRfbWF0Y2hbXSA9IHsKIAl7IC5jb21w YXRpYmxlID0gImJyY20sYmNtMjgzNS1odnMiIH0sCiAJe30KIH07CitNT0RVTEVfREVWSUNFX1RB QkxFKG9mLCB2YzRfaHZzX2R0X21hdGNoKTsKIAogc3RydWN0IHBsYXRmb3JtX2RyaXZlciB2YzRf aHZzX2RyaXZlciA9IHsKIAkucHJvYmUgPSB2YzRfaHZzX2Rldl9wcm9iZSwKZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3YzZC5jIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRf djNkLmMKaW5kZXggYmZjMmZhNzNkMmFlLi5lNzdlOWViYmFiNGIgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvZ3B1L2RybS92YzQvdmM0X3YzZC5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3Yz ZC5jCkBAIC00NTksNiArNDU5LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQg dmM0X3YzZF9kdF9tYXRjaFtdID0gewogCXsgLmNvbXBhdGlibGUgPSAiYnJjbSx2YzQtdjNkIiB9 LAogCXt9CiB9OworTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgdmM0X3YzZF9kdF9tYXRjaCk7CiAK IHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgdmM0X3YzZF9kcml2ZXIgPSB7CiAJLnByb2JlID0gdmM0 X3YzZF9kZXZfcHJvYmUsCi0tIAoyLjE3LjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric@anholt.net (Eric Anholt) Date: Mon, 16 Apr 2018 10:25:46 -0700 Subject: [PATCH v2 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node. In-Reply-To: <20180413175632.oz62n363g6rxdp6z@rob-hp-laptop> References: <20180413175632.oz62n363g6rxdp6z@rob-hp-laptop> Message-ID: <20180416172546.32118-1-eric@anholt.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The GPU subsystem node was a workaround to have a central device to bind V3D and display to. Following the lead of 246774d17fc0 ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove the subsystem node usage and just create a platform device for the DRM device to attach to if any of the subsystem devices are present. v2: Simplify the DT walking code. Signed-off-by: Eric Anholt --- .../bindings/display/brcm,bcm-vc4.txt | 7 ----- drivers/gpu/drm/vc4/vc4_drv.c | 29 ++++++++++++++----- drivers/gpu/drm/vc4/vc4_hvs.c | 1 + drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 4 files changed, 23 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt index 284e2b14cfbe..5fd4717101d6 100644 --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt @@ -4,9 +4,6 @@ The VC4 device present on the Raspberry Pi includes a display system with HDMI output and the HVS (Hardware Video Scaler) for compositing display planes. -Required properties for VC4: -- compatible: Should be "brcm,bcm2835-vc4" or "brcm,cygnus-vc4" - Required properties for Pixel Valve: - compatible: Should be one of "brcm,bcm2835-pixelvalve0", "brcm,bcm2835-pixelvalve1", or "brcm,bcm2835-pixelvalve2" @@ -153,10 +150,6 @@ v3d: v3d at 7ec00000 { interrupts = <1 10>; }; -vc4: gpu { - compatible = "brcm,bcm2835-vc4"; -}; - panel: panel { compatible = "ontat,yx700wv03", "simple-panel"; diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 7c95ed5c5cac..13b840b534b8 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -364,22 +364,30 @@ static int vc4_platform_drm_remove(struct platform_device *pdev) return 0; } -static const struct of_device_id vc4_of_match[] = { - { .compatible = "brcm,bcm2835-vc4", }, - { .compatible = "brcm,cygnus-vc4", }, - {}, -}; -MODULE_DEVICE_TABLE(of, vc4_of_match); - static struct platform_driver vc4_platform_driver = { .probe = vc4_platform_drm_probe, .remove = vc4_platform_drm_remove, .driver = { .name = "vc4-drm", - .of_match_table = vc4_of_match, }, }; +static bool +driver_of_table_has_a_match(const struct platform_driver *driver) +{ + struct device_node *node; + + node = of_find_matching_node_and_match(NULL, + driver->driver.of_match_table, + NULL); + if (of_device_is_available(node)) { + of_node_put(node); + return true; + } + + return false; +} + static int __init vc4_drm_register(void) { int ret; @@ -389,6 +397,11 @@ static int __init vc4_drm_register(void) if (ret) return ret; + if (driver_of_table_has_a_match(&vc4_v3d_driver) || + driver_of_table_has_a_match(&vc4_hvs_driver)) { + platform_device_register_simple("vc4-drm", -1, NULL, 0); + } + return platform_driver_register(&vc4_platform_driver); } diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c index 2b62fc5b8d85..730813ee74ae 100644 --- a/drivers/gpu/drm/vc4/vc4_hvs.c +++ b/drivers/gpu/drm/vc4/vc4_hvs.c @@ -262,6 +262,7 @@ static const struct of_device_id vc4_hvs_dt_match[] = { { .compatible = "brcm,bcm2835-hvs" }, {} }; +MODULE_DEVICE_TABLE(of, vc4_hvs_dt_match); struct platform_driver vc4_hvs_driver = { .probe = vc4_hvs_dev_probe, diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index bfc2fa73d2ae..e77e9ebbab4b 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -459,6 +459,7 @@ static const struct of_device_id vc4_v3d_dt_match[] = { { .compatible = "brcm,vc4-v3d" }, {} }; +MODULE_DEVICE_TABLE(of, vc4_v3d_dt_match); struct platform_driver vc4_v3d_driver = { .probe = vc4_v3d_dev_probe, -- 2.17.0