From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bh-25.webhostbox.net ([208.91.199.152]:60039 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752750AbeDPSFc (ORCPT ); Mon, 16 Apr 2018 14:05:32 -0400 Date: Mon, 16 Apr 2018 10:28:58 -0700 From: Guenter Roeck To: Ahsan Hussain Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, chombour , ahsann , m.purski@samsung.com Subject: Re: [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking Message-ID: <20180416172858.GA9447@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Mon, Apr 16, 2018 at 10:08:19PM +0500, Ahsan Hussain wrote: > > Upstream commit > > 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed") > This doesn't have to be on separate lines; as written, it just causes confusion. > makes ina2xx_set_shunt() call mutex_lock on an un-initialized mutex. > Initialize it prior so we don't get a NULL pointer dereference error > > Signed-off-by: Ahsan Hussain Good find, but your patch is corrupted to the point where any attenpt to fix it up on my side failed. Please resend without corruption, and please provide a Fixes: line. Thanks, Guenter > --- > drivers/hwmon/ina2xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c > index a629f7c..1304f01 100644 > --- a/drivers/hwmon/ina2xx.c > +++ b/drivers/hwmon/ina2xx.c > @@ -457,6 +457,8 @@ static int ina2xx_probe(struct i2c_client *client, > val = INA2XX_RSHUNT_DEFAULT; > } > + mutex_init(&data->config_lock); > + > ina2xx_set_shunt(data, val); > ina2xx_regmap_config.max_register = data->config->registers; > @@ -473,8 +475,6 @@ static int ina2xx_probe(struct i2c_client *client, > return -ENODEV; > } > - mutex_init(&data->config_lock); > - > data->groups[group++] = &ina2xx_group; > if (id->driver_data == ina226) > data->groups[group++] = &ina226_group; > -- > 2.7.4 >