All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v4 3/4] btrfs: Refactor btrfs_ioctl_snap_destroy() by using btrfs_delete_subvolume()
Date: Mon, 16 Apr 2018 19:53:30 +0200	[thread overview]
Message-ID: <20180416175330.GS21272@twin.jikos.cz> (raw)
In-Reply-To: <e4e8ecc3-fc4f-5967-1bf3-9f5abbac0c62@jp.fujitsu.com>

On Wed, Apr 11, 2018 at 02:20:49PM +0900, Misono Tomohiro wrote:
> Use btrfs_delete_subvolume() to refactor btrfs_ioctl_snap_destroy().
> The permission check is still done in btrfs_ioctl_snap_destroy(). Also,
> call of d_delete() is still required since btrfs_delete_subvolume()
> does not call it.
> 
> As a result, btrfs_unlink_subvol() and may_destroy_subvol()
> become static functions. No functional change happens.
> 
> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>

Why is this still split into two patches? Factoring out a function
should happen in one patch, ie 2 and 3 in one go. Do you have a reason
not to do it like that?

  reply	other threads:[~2018-04-16 17:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11  5:18 [PATCH v4 0/4] Allow rmdir(2) to delete a subvolume Misono Tomohiro
2018-04-11  5:19 ` [PATCH v4 1/4] btrfs: move may_destroy_subvol() from ioctl.c to inode.c Misono Tomohiro
2018-04-11  5:20 ` [PATCH v4 2/4] btrfs: Add definition of btrfs_delete_subvolume() Misono Tomohiro
2018-04-11  5:20 ` [PATCH v4 3/4] btrfs: Refactor btrfs_ioctl_snap_destroy() by using btrfs_delete_subvolume() Misono Tomohiro
2018-04-16 17:53   ` David Sterba [this message]
2018-04-17  0:21     ` Misono Tomohiro
2018-04-17 17:03       ` David Sterba
2018-04-11  5:22 ` [PATCH v4 4/4] btrfs: Allow rmdir(2) to delete an empty subvolume Misono Tomohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416175330.GS21272@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=misono.tomohiro@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.