From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org (imap.thunk.org [IPv6:2600:3c02::f03c:91ff:fe96:be03]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7402B2244E41C for ; Mon, 16 Apr 2018 17:14:33 -0700 (PDT) Date: Mon, 16 Apr 2018 20:14:22 -0400 From: "Theodore Y. Ts'o" Subject: Re: [PATCH] dax: Change return type to vm_fault_t Message-ID: <20180417001421.GH22870@thunk.org> References: <20180414155059.GA18015@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Michal Hocko , linux-nvdimm , Matthew Wilcox , Linux MM , Souptick Joarder , Andrew Morton List-ID: On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote: > Ugh, so this change to vmf_insert_mixed() went upstream without fixing > the users? This changelog is now misleading as it does not mention > that is now an urgent standalone fix. On first read I assumed this was > part of a wider effort for 4.18. Why is this an urgent fix? I thought all the return type change was did something completely innocuous that would not cause any real difference. Otherwise there are a dozen plus "fixups" to change the users that will now become urgent fixes, which I did *not* expect to be the case. (Where two are in ext2 and ext4, and where I planned to take my time and get them fixed in the next merge window, precisely becuase I did not *think* they were urgent.) - Ted _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f199.google.com (mail-yw0-f199.google.com [209.85.161.199]) by kanga.kvack.org (Postfix) with ESMTP id E9D236B0003 for ; Mon, 16 Apr 2018 20:14:33 -0400 (EDT) Received: by mail-yw0-f199.google.com with SMTP id c184so2357065ywh.5 for ; Mon, 16 Apr 2018 17:14:33 -0700 (PDT) Received: from imap.thunk.org (imap.thunk.org. [2600:3c02::f03c:91ff:fe96:be03]) by mx.google.com with ESMTPS id m5si855554ywf.598.2018.04.16.17.14.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 17:14:32 -0700 (PDT) Date: Mon, 16 Apr 2018 20:14:22 -0400 From: "Theodore Y. Ts'o" Subject: Re: [PATCH] dax: Change return type to vm_fault_t Message-ID: <20180417001421.GH22870@thunk.org> References: <20180414155059.GA18015@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: Souptick Joarder , linux-nvdimm , Matthew Wilcox , Linux MM , Andrew Morton , Michal Hocko On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote: > Ugh, so this change to vmf_insert_mixed() went upstream without fixing > the users? This changelog is now misleading as it does not mention > that is now an urgent standalone fix. On first read I assumed this was > part of a wider effort for 4.18. Why is this an urgent fix? I thought all the return type change was did something completely innocuous that would not cause any real difference. Otherwise there are a dozen plus "fixups" to change the users that will now become urgent fixes, which I did *not* expect to be the case. (Where two are in ext2 and ext4, and where I planned to take my time and get them fixed in the next merge window, precisely becuase I did not *think* they were urgent.) - Ted