From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 822992263DD6D for ; Mon, 16 Apr 2018 17:19:11 -0700 (PDT) Date: Mon, 16 Apr 2018 17:19:07 -0700 From: Matthew Wilcox Subject: Re: [PATCH] dax: Change return type to vm_fault_t Message-ID: <20180417001907.GB25048@bombadil.infradead.org> References: <20180414155059.GA18015@jordon-HP-15-Notebook-PC> <20180417001421.GH22870@thunk.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180417001421.GH22870@thunk.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Theodore Y. Ts'o" Cc: Michal Hocko , linux-nvdimm , Linux MM , Souptick Joarder , Andrew Morton List-ID: On Mon, Apr 16, 2018 at 08:14:22PM -0400, Theodore Y. Ts'o wrote: > On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote: > > Ugh, so this change to vmf_insert_mixed() went upstream without fixing > > the users? This changelog is now misleading as it does not mention > > that is now an urgent standalone fix. On first read I assumed this was > > part of a wider effort for 4.18. > > Why is this an urgent fix? I thought all the return type change was > did something completely innocuous that would not cause any real > difference. Keep reading the thread; Dan is mistaken. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 4C12B6B0003 for ; Mon, 16 Apr 2018 20:19:13 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id o2-v6so3408497plk.0 for ; Mon, 16 Apr 2018 17:19:13 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id k7si10639772pgq.286.2018.04.16.17.19.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 17:19:11 -0700 (PDT) Date: Mon, 16 Apr 2018 17:19:07 -0700 From: Matthew Wilcox Subject: Re: [PATCH] dax: Change return type to vm_fault_t Message-ID: <20180417001907.GB25048@bombadil.infradead.org> References: <20180414155059.GA18015@jordon-HP-15-Notebook-PC> <20180417001421.GH22870@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417001421.GH22870@thunk.org> Sender: owner-linux-mm@kvack.org List-ID: To: "Theodore Y. Ts'o" Cc: Dan Williams , Souptick Joarder , linux-nvdimm , Linux MM , Andrew Morton , Michal Hocko On Mon, Apr 16, 2018 at 08:14:22PM -0400, Theodore Y. Ts'o wrote: > On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote: > > Ugh, so this change to vmf_insert_mixed() went upstream without fixing > > the users? This changelog is now misleading as it does not mention > > that is now an urgent standalone fix. On first read I assumed this was > > part of a wider effort for 4.18. > > Why is this an urgent fix? I thought all the return type change was > did something completely innocuous that would not cause any real > difference. Keep reading the thread; Dan is mistaken.