All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs: cap the length of deduplication requests
Date: Mon, 16 Apr 2018 23:58:00 -0700	[thread overview]
Message-ID: <20180417065800.GA2857@infradead.org> (raw)
In-Reply-To: <20180417051918.GD5203@magnolia>

On Mon, Apr 16, 2018 at 10:19:18PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Since deduplication potentially has to read in all the pages in both
> files in order to compare the contents, cap the deduplication request
> length at MAX_RW_COUNT (roughly 2GB) so that we have /some/ upper bound
> on the request length and can't just lock up the kernel forever.  Found
> by running generic/304 after commit 1ddae54555b62 ("common/rc: add
> missing 'local' keywords").

Looks fine.  btrfs limits to 16MB, I guess we don't want to go that low?

  reply	other threads:[~2018-04-17  6:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  5:19 [PATCH] xfs: cap the length of deduplication requests Darrick J. Wong
2018-04-17  6:58 ` Christoph Hellwig [this message]
2018-04-17 15:44   ` Darrick J. Wong
2018-04-18  2:57 ` [PATCH v2] " Darrick J. Wong
2018-04-22  2:57   ` Amir Goldstein
2018-04-22 13:53     ` Darrick J. Wong
2018-05-02 15:30   ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417065800.GA2857@infradead.org \
    --to=hch@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.