From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH v5 01/11] net/mlx4: fix RSS resource leak in
 case of error
Date: Tue, 17 Apr 2018 11:19:40 +0200
Message-ID: <20180417091940.fe5k5arwzwsgenr7@laranjeiro-vm.dev.6wind.com>
References: <20180410161132.8776-1-adrien.mazarguil@6wind.com>
 <20180416150058.2620-1-adrien.mazarguil@6wind.com>
 <20180416150058.2620-2-adrien.mazarguil@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, stable@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com
 [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 16C01A491
 for <dev@dpdk.org>; Tue, 17 Apr 2018 11:19:08 +0200 (CEST)
Received: by mail-wr0-f193.google.com with SMTP id q6so21326509wrd.6
 for <dev@dpdk.org>; Tue, 17 Apr 2018 02:19:08 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180416150058.2620-2-adrien.mazarguil@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 16, 2018 at 06:21:48PM +0200, Adrien Mazarguil wrote:
> When memory cannot be allocated for a flow rule, its RSS context reference
> is not dropped.
> 
> Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> ---
>  drivers/net/mlx4/mlx4_flow.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
> index f3063ee8a..2b4bf7094 100644
> --- a/drivers/net/mlx4/mlx4_flow.c
> +++ b/drivers/net/mlx4/mlx4_flow.c
> @@ -820,11 +820,14 @@ mlx4_flow_prepare(struct priv *priv,
>  			},
>  		};
>  
> -		if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec)))
> +		if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) {
> +			if (temp.rss)
> +				mlx4_rss_put(temp.rss);
>  			return rte_flow_error_set
>  				(error, -rte_errno,
>  				 RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
>  				 "flow rule handle allocation failure");
> +		}
>  		/* Most fields will be updated by second pass. */
>  		*flow = (struct rte_flow){
>  			.ibv_attr = temp.ibv_attr,
> -- 
> 2.11.0

-- 
Nélio Laranjeiro
6WIND