All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fan Zhang <roy.fan.zhang@intel.com>
To: dev@dpdk.org
Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com
Subject: [PATCH v2] examples/ip_pipeline: fix buffer not null terminated
Date: Tue, 17 Apr 2018 10:52:52 +0100	[thread overview]
Message-ID: <20180417095252.81275-1-roy.fan.zhang@intel.com> (raw)
In-Reply-To: <20180416110233.66450-1-roy.fan.zhang@intel.com>

Coverity issue: 272572
Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v2:
- use more generic strlcpy approach

 examples/ip_pipeline/action.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
index 77a04fe19..1203bb892 100644
--- a/examples/ip_pipeline/action.c
+++ b/examples/ip_pipeline/action.c
@@ -6,6 +6,8 @@
 #include <stdlib.h>
 #include <string.h>
 
+#include <rte_string_fns.h>
+
 #include "action.h"
 #include "hash_func.h"
 
@@ -133,7 +135,7 @@ port_in_action_profile_create(const char *name,
 	}
 
 	/* Node fill in */
-	strncpy(profile->name, name, sizeof(profile->name));
+	strlcpy(profile->name, name, sizeof(profile->name));
 	memcpy(&profile->params, params, sizeof(*params));
 	profile->ap = ap;
 
-- 
2.13.6

  parent reply	other threads:[~2018-04-17 10:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 11:02 [PATCH] examples/ip_pipeline: fix buffer not null terminated Fan Zhang
2018-04-16 13:17 ` Bruce Richardson
2018-04-17  9:52 ` Fan Zhang [this message]
2018-04-17 11:18   ` [PATCH v2] " Bruce Richardson
2018-05-08 14:28 ` [PATCH] " Dumitrescu, Cristian
2018-05-08 19:51   ` Bruce Richardson
2018-05-09  9:26     ` Dumitrescu, Cristian
2018-04-17  9:45 [PATCH v2] " Fan Zhang
2018-04-17 11:23 ` Bruce Richardson
2018-05-08 14:29 ` Dumitrescu, Cristian
2018-04-17 13:28 [PATCH] " Jasvinder Singh
2018-04-17 16:39 ` [PATCH v2] " Jasvinder Singh
2018-05-08 14:29   ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417095252.81275-1-roy.fan.zhang@intel.com \
    --to=roy.fan.zhang@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.