From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8ROK-0006KA-PB for qemu-devel@nongnu.org; Tue, 17 Apr 2018 10:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8ROE-0007lA-Ux for qemu-devel@nongnu.org; Tue, 17 Apr 2018 10:15:28 -0400 Received: from smtp03.citrix.com ([162.221.156.55]:11272) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8ROE-0007jM-9P for qemu-devel@nongnu.org; Tue, 17 Apr 2018 10:15:22 -0400 Date: Tue, 17 Apr 2018 15:15:18 +0100 From: Anthony PERARD Message-ID: <20180417141518.GM2208@perard> References: <1523049683-11782-1-git-send-email-igor.druzhinin@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1523049683-11782-1-git-send-email-igor.druzhinin@citrix.com> Subject: Re: [Qemu-devel] [PATCH] xen/pt: use address_space_memory object for memory region hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Druzhinin Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, sstabellini@kernel.org, ross.lagerwall@citrix.com On Fri, Apr 06, 2018 at 10:21:23PM +0100, Igor Druzhinin wrote: > Commit 99605175c (xen-pt: Fix PCI devices re-attach failed) introduced > a subtle bug. As soon as the guest switches off Bus Mastering on the > device it immediately causes all the BARs be unmapped due to the DMA > address space of the device being changed. This is undesired behavior > because the guest may try to communicate with the device after that > which triggers the following errors in the logs: > > [00:05.0] xen_pt_bar_read: Error: Should not read BAR through QEMU. @0x0000000000000200 > [00:05.0] xen_pt_bar_write: Error: Should not write BAR through QEMU. @0x0000000000000200 > > The issue that the original patch tried to workaround (uneven number of > region_add/del calls on device attach/detach) was fixed in later QEMU > versions. Do you know when the issue was fixed? -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH] xen/pt: use address_space_memory object for memory region hooks Date: Tue, 17 Apr 2018 15:15:18 +0100 Message-ID: <20180417141518.GM2208@perard> References: <1523049683-11782-1-git-send-email-igor.druzhinin@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1f8ROE-0001VL-Em for xen-devel@lists.xenproject.org; Tue, 17 Apr 2018 14:15:22 +0000 Content-Disposition: inline In-Reply-To: <1523049683-11782-1-git-send-email-igor.druzhinin@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Igor Druzhinin Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, qemu-devel@nongnu.org, ross.lagerwall@citrix.com List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBBcHIgMDYsIDIwMTggYXQgMTA6MjE6MjNQTSArMDEwMCwgSWdvciBEcnV6aGluaW4g d3JvdGU6Cj4gQ29tbWl0IDk5NjA1MTc1YyAoeGVuLXB0OiBGaXggUENJIGRldmljZXMgcmUtYXR0 YWNoIGZhaWxlZCkgaW50cm9kdWNlZAo+IGEgc3VidGxlIGJ1Zy4gQXMgc29vbiBhcyB0aGUgZ3Vl c3Qgc3dpdGNoZXMgb2ZmIEJ1cyBNYXN0ZXJpbmcgb24gdGhlCj4gZGV2aWNlIGl0IGltbWVkaWF0 ZWx5IGNhdXNlcyBhbGwgdGhlIEJBUnMgYmUgdW5tYXBwZWQgZHVlIHRvIHRoZSBETUEKPiBhZGRy ZXNzIHNwYWNlIG9mIHRoZSBkZXZpY2UgYmVpbmcgY2hhbmdlZC4gVGhpcyBpcyB1bmRlc2lyZWQg YmVoYXZpb3IKPiBiZWNhdXNlIHRoZSBndWVzdCBtYXkgdHJ5IHRvIGNvbW11bmljYXRlIHdpdGgg dGhlIGRldmljZSBhZnRlciB0aGF0Cj4gd2hpY2ggdHJpZ2dlcnMgdGhlIGZvbGxvd2luZyBlcnJv cnMgaW4gdGhlIGxvZ3M6Cj4gCj4gWzAwOjA1LjBdIHhlbl9wdF9iYXJfcmVhZDogRXJyb3I6IFNo b3VsZCBub3QgcmVhZCBCQVIgdGhyb3VnaCBRRU1VLiBAMHgwMDAwMDAwMDAwMDAwMjAwCj4gWzAw OjA1LjBdIHhlbl9wdF9iYXJfd3JpdGU6IEVycm9yOiBTaG91bGQgbm90IHdyaXRlIEJBUiB0aHJv dWdoIFFFTVUuIEAweDAwMDAwMDAwMDAwMDAyMDAKPiAKPiBUaGUgaXNzdWUgdGhhdCB0aGUgb3Jp Z2luYWwgcGF0Y2ggdHJpZWQgdG8gd29ya2Fyb3VuZCAodW5ldmVuIG51bWJlciBvZgo+IHJlZ2lv bl9hZGQvZGVsIGNhbGxzIG9uIGRldmljZSBhdHRhY2gvZGV0YWNoKSB3YXMgZml4ZWQgaW4gbGF0 ZXIgUUVNVQo+IHZlcnNpb25zLgoKRG8geW91IGtub3cgd2hlbiB0aGUgaXNzdWUgd2FzIGZpeGVk PwoKLS0gCkFudGhvbnkgUEVSQVJECgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v eGVuLWRldmVs