[PATCH] hwtracing: intel_th: Change return type to vm_fault_t

[PATCH] hwtracing: intel_th: Change return type to vm_fault_t

[Souptick Joarder]

Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to
vm_fault_t")

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/hwtracing/intel_th/msu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index dfb57ea..0ac84eb 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
 	mutex_unlock(&msc->buf_mutex);
 }

-static int msc_mmap_fault(struct vm_fault *vmf)
+static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
 {
 	struct msc_iter *iter = vmf->vma->vm_file->private_data;
 	struct msc *msc = iter->msc;
--
1.9.1

Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t

[Souptick Joarder]

Any comment for this patch ?

On Tue, Apr 17, 2018 at 7:45 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  drivers/hwtracing/intel_th/msu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
> index dfb57ea..0ac84eb 100644
> --- a/drivers/hwtracing/intel_th/msu.c
> +++ b/drivers/hwtracing/intel_th/msu.c
> @@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
>         mutex_unlock(&msc->buf_mutex);
>  }
>
> -static int msc_mmap_fault(struct vm_fault *vmf)
> +static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
>  {
>         struct msc_iter *iter = vmf->vma->vm_file->private_data;
>         struct msc *msc = iter->msc;
> --
> 1.9.1
>

Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t

[Alexander Shishkin]

On Wed, May 02, 2018 at 11:14:48AM +0530, Souptick Joarder wrote:
> Any comment for this patch ?

Looks good, I'm queuing this one for the next merge window.

Thanks you!

Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t

[Souptick Joarder]

On Wed, May 2, 2018 at 7:32 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> On 02-May-2018 7:28 PM, "Alexander Shishkin"
> <alexander.shishkin@linux.intel.com> wrote:
>>
>> On Wed, May 02, 2018 at 11:14:48AM +0530, Souptick Joarder wrote:
>> > Any comment for this patch ?
>>
>> Looks good, I'm queuing this one for the next merge window.
>>

This patch is not merged in 4.18-rc-1.

[PATCH] hwtracing: intel_th: Change return type to vm_fault_t

[Souptick Joarder]

Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.

see commit 1c8f422059ae ("mm: change return type to
vm_fault_t") for reference.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/hwtracing/intel_th/msu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index dfb57ea..0ac84eb 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
 	mutex_unlock(&msc->buf_mutex);
 }

-static int msc_mmap_fault(struct vm_fault *vmf)
+static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
 {
 	struct msc_iter *iter = vmf->vma->vm_file->private_data;
 	struct msc *msc = iter->msc;
--
1.9.1