From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v1 0/3] nvmet-rdma automatic port re-activation
Date: Tue, 17 Apr 2018 17:43:32 +0200 [thread overview]
Message-ID: <20180417154332.GA26352@lst.de> (raw)
In-Reply-To: <0f781a93-2cbf-8d60-2028-4581912bf07a@grimberg.me>
On Sun, Apr 15, 2018@11:53:02AM +0300, Sagi Grimberg wrote:
>>> When a RDMA device goes away we must destroy all it's associated
>>> RDMA resources. RDMa device resets also manifest as device removal
>>> events and a short while after they come back. We want to re-activate
>>> a port listener on this RDMA device when it comes back in to the system.
>>
>> I really detest this series. It just shows how messed up the whole
>> IB core interaction is. The right way to fix this is to stop treating
>> a IB device reset as a device removal, and give it a different event.
>>
>> And also make sure we have a single unified event system instead of
>> three separate ones.
>
> I've raised this claim before, but got resistance from Doug:
> https://www.spinics.net/lists/linux-rdma/msg59815.html
>
> At that point, in the lack of change in the RDMA interface, this
> is pretty much what we can do to support device resets...
Meh. I really hate all that rubbish boilerplate code. Nothing
in here is protocol specific, so even without a proper reset
even it is something that should be done in common code.
next prev parent reply other threads:[~2018-04-17 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 8:06 [PATCH v1 0/3] nvmet-rdma automatic port re-activation Sagi Grimberg
2018-04-12 8:06 ` [PATCH v1 1/3] nvmet-rdma: automatic listening " Sagi Grimberg
2018-04-12 13:08 ` Israel Rukshin
2018-04-12 8:06 ` [PATCH v1 2/3] nvmet: Add fabrics ops to port Sagi Grimberg
2018-04-12 8:06 ` [PATCH v1 3/3] nvmet: Add port transport state flag Sagi Grimberg
2018-04-13 17:14 ` Christoph Hellwig
2018-04-15 8:54 ` Sagi Grimberg
2018-04-17 15:28 ` Christoph Hellwig
2018-05-16 12:40 ` Max Gurtovoy
2018-04-12 8:06 ` [PATCH 4/3 v1 nvmetcli] nvmetcli: expose nvmet port status and state Sagi Grimberg
2018-04-12 11:25 ` Nitzan Carmi
2018-04-12 12:34 ` Sagi Grimberg
2018-04-13 17:00 ` [PATCH v1 0/3] nvmet-rdma automatic port re-activation Christoph Hellwig
2018-04-15 8:53 ` Sagi Grimberg
2018-04-17 15:43 ` Christoph Hellwig [this message]
2018-04-20 2:48 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417154332.GA26352@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.