From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH hwc v2 11/18] drm_hwcomposer: Add utility functions to copy displaycomposition internals Date: Tue, 17 Apr 2018 12:34:48 -0400 Message-ID: <20180417163448.GG73214@art_vandelay> References: <1523460149-1740-1-git-send-email-alexandru-cosmin.gheorghe@arm.com> <1523460149-1740-12-git-send-email-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-x241.google.com (mail-yw0-x241.google.com [IPv6:2607:f8b0:4002:c05::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id B29A089E03 for ; Tue, 17 Apr 2018 16:34:50 +0000 (UTC) Received: by mail-yw0-x241.google.com with SMTP id q12so8270755ywj.0 for ; Tue, 17 Apr 2018 09:34:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1523460149-1740-12-git-send-email-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru Gheorghe Cc: ayan.halder@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMTEsIDIwMTggYXQgMDQ6MjI6MjJQTSArMDEwMCwgQWxleGFuZHJ1IEdoZW9y Z2hlIHdyb3RlOgo+IEFkZCB1dGlsaXR5IGZ1bmN0aW9ucyB0byBjb3B5IHRoZSBEcm1Id2NMYXll ciBhbmQgRHJtQ29tcG9zaXRpb25QbGFuZXMKPiBmcm9tIGFub3RoZXIgRHJtRGlzcGxheUNvbXBv c2l0aW9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFsZXhhbmRydSBHaGVvcmdoZSA8YWxleGFuZHJ1 LWNvc21pbi5naGVvcmdoZUBhcm0uY29tPgo+IC0tLQo+ICBkcm1kaXNwbGF5Y29tcG9zaXRpb24u Y3BwIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgZHJtZGlzcGxheWNvbXBv c2l0aW9uLmggICB8ICAzICsrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKykK PiAKPiBkaWZmIC0tZ2l0IGEvZHJtZGlzcGxheWNvbXBvc2l0aW9uLmNwcCBiL2RybWRpc3BsYXlj b21wb3NpdGlvbi5jcHAKPiBpbmRleCA2NmU2N2E0Li5kZDY0ZjQ2IDEwMDY0NAo+IC0tLSBhL2Ry bWRpc3BsYXljb21wb3NpdGlvbi5jcHAKPiArKysgYi9kcm1kaXNwbGF5Y29tcG9zaXRpb24uY3Bw Cj4gQEAgLTk5LDYgKzk5LDM1IEBAIGludCBEcm1EaXNwbGF5Q29tcG9zaXRpb246OlNldExheWVy cyhEcm1Id2NMYXllciAqbGF5ZXJzLCBzaXplX3QgbnVtX2xheWVycywKPiAgICByZXR1cm4gMDsK PiAgfQo+ICAKPiAraW50IERybURpc3BsYXlDb21wb3NpdGlvbjo6Q29weUxheWVycyhEcm1EaXNw bGF5Q29tcG9zaXRpb24gKnNyYykgewo+ICsgIGdlb21ldHJ5X2NoYW5nZWRfID0gdHJ1ZTsKPiAr ICB0eXBlXyA9IERSTV9DT01QT1NJVElPTl9UWVBFX0ZSQU1FOwo+ICsgIHN0ZDo6c2hhcmVkX3B0 cjxJbXBvcnRlcj4gaW1wb3J0ZXIgPQo+ICsgICAgICBkcm1fLT5yZXNvdXJjZV9tYW5hZ2VyKCkt PkdldEltcG9ydGVyKGNydGMoKS0+ZGlzcGxheSgpKTsKPiArICBpZiAoIWltcG9ydGVyKSB7Cj4g KyAgICBBTE9HRSgiRmFpbGVkIHRvIGZpbmQgYSB2YWxpZCBpbXBvcnRlciIpOwo+ICsgICAgcmV0 dXJuIC1FSU5WQUw7Cj4gKyAgfQo+ICsgIGZvciAoRHJtSHdjTGF5ZXIgJnNyY19sYXllciA6IHNy Yy0+bGF5ZXJzKCkpIHsKPiArICAgIERybUh3Y0xheWVyIGNvcHk7Cj4gKyAgICBjb3B5LlBvcHVs YXRlRnJvbURybUh3Y0xheWVyKCZzcmNfbGF5ZXIpOwo+ICsgICAgaW50IHJldCA9IGNvcHkuSW1w b3J0QnVmZmVyKGltcG9ydGVyLmdldCgpLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGRybV8tPnJlc291cmNlX21hbmFnZXIoKS0+R2V0R3JhbGxvYygpKTsKPiArICAgIGlmIChy ZXQpIHsKPiArICAgICAgQUxPR0UoIkZhaWxlZCB0byBpbXBvcnQgYnVmZmVyIHJldCA9ICVkIiwg cmV0KTsKPiArICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gKyAgICB9Cj4gKyAgICBsYXllcnNfLmVt cGxhY2VfYmFjayhzdGQ6Om1vdmUoY29weSkpOwo+ICsgIH0KPiArICByZXR1cm4gMDsKPiArfQoK VGhpcyBzZWVtcyB0byBkbyBtb3JlIHRoYW4ganVzdCBDb3B5TGF5ZXJzLCBhbmQgaXQgc2VlbXMg cXVpdGUgc3BlY2lhbGl6ZWQgdG8KeW91ciBwdXJwb3NlLiBDYW4geW91IGRvIHNvbWV0aGluZyBz aW1pbGFyIHRvIFNxdWFzaEZyYW1lKCksIHdoZXJlIHRoZSBuZXcKY29tcG9zaXRpb24gaXMgY3Jh ZnRlZCBpbiBjb250ZXh0PyBJdCBtaWdodCBiZSBhIGxpdHRsZSBsZXNzIGF3a3dhcmQgdGhhbgpz cHJpbmtsaW5nIGluIHRoZXNlIHNlZW1pbmdseSBnZW5lcmljIGNvcHkgZnVuY3Rpb25zLgoKU2Vh bgoKPiArCj4gK3ZvaWQgRHJtRGlzcGxheUNvbXBvc2l0aW9uOjpDb3B5Q29tcFBsYW5lcyhEcm1E aXNwbGF5Q29tcG9zaXRpb24gKnNyYykgewo+ICsgIGZvciAoYXV0byBjb21wX3BsYW5lIDogc3Jj LT5jb21wb3NpdGlvbl9wbGFuZXMoKSkgewo+ICsgICAgY29tcG9zaXRpb25fcGxhbmVzXy5wdXNo X2JhY2soY29tcF9wbGFuZSk7Cj4gKyAgfQo+ICt9Cj4gKwo+ICBpbnQgRHJtRGlzcGxheUNvbXBv c2l0aW9uOjpTZXREcG1zTW9kZSh1aW50MzJfdCBkcG1zX21vZGUpIHsKPiAgICBpZiAoIXZhbGlk YXRlX2NvbXBvc2l0aW9uX3R5cGUoRFJNX0NPTVBPU0lUSU9OX1RZUEVfRFBNUykpCj4gICAgICBy ZXR1cm4gLUVJTlZBTDsKPiBkaWZmIC0tZ2l0IGEvZHJtZGlzcGxheWNvbXBvc2l0aW9uLmggYi9k cm1kaXNwbGF5Y29tcG9zaXRpb24uaAo+IGluZGV4IDkxODM5MjUuLmM2NDY0MjAgMTAwNjQ0Cj4g LS0tIGEvZHJtZGlzcGxheWNvbXBvc2l0aW9uLmgKPiArKysgYi9kcm1kaXNwbGF5Y29tcG9zaXRp b24uaAo+IEBAIC02OCw2ICs2OCw3IEBAIGNsYXNzIERybUNvbXBvc2l0aW9uUGxhbmUgewo+ICAK PiAgICBEcm1Db21wb3NpdGlvblBsYW5lKCkgPSBkZWZhdWx0Owo+ICAgIERybUNvbXBvc2l0aW9u UGxhbmUoRHJtQ29tcG9zaXRpb25QbGFuZSAmJnJocykgPSBkZWZhdWx0Owo+ICsgIERybUNvbXBv c2l0aW9uUGxhbmUoY29uc3QgRHJtQ29tcG9zaXRpb25QbGFuZSAmcmhzKSA9IGRlZmF1bHQ7Cj4g ICAgRHJtQ29tcG9zaXRpb25QbGFuZSAmb3BlcmF0b3I9KERybUNvbXBvc2l0aW9uUGxhbmUgJiZv dGhlcikgPSBkZWZhdWx0Owo+ICAgIERybUNvbXBvc2l0aW9uUGxhbmUoVHlwZSB0eXBlLCBEcm1Q bGFuZSAqcGxhbmUsIERybUNydGMgKmNydGMpCj4gICAgICAgIDogdHlwZV8odHlwZSksIHBsYW5l XyhwbGFuZSksIGNydGNfKGNydGMpIHsKPiBAQCAtMTIwLDYgKzEyMSw4IEBAIGNsYXNzIERybURp c3BsYXlDb21wb3NpdGlvbiB7Cj4gICAgICAgICAgICAgUGxhbm5lciAqcGxhbm5lciwgdWludDY0 X3QgZnJhbWVfbm8pOwo+ICAKPiAgICBpbnQgU2V0TGF5ZXJzKERybUh3Y0xheWVyICpsYXllcnMs IHNpemVfdCBudW1fbGF5ZXJzLCBib29sIGdlb21ldHJ5X2NoYW5nZWQpOwo+ICsgIGludCBDb3B5 TGF5ZXJzKERybURpc3BsYXlDb21wb3NpdGlvbiAqc3JjKTsKPiArICB2b2lkIENvcHlDb21wUGxh bmVzKERybURpc3BsYXlDb21wb3NpdGlvbiAqc3JjKTsKPiAgICBpbnQgQWRkUGxhbmVDb21wb3Np dGlvbihEcm1Db21wb3NpdGlvblBsYW5lIHBsYW5lKTsKPiAgICBpbnQgQWRkUGxhbmVEaXNhYmxl KERybVBsYW5lICpwbGFuZSk7Cj4gICAgaW50IFNldERwbXNNb2RlKHVpbnQzMl90IGRwbXNfbW9k ZSk7Cj4gLS0gCj4gMi43LjQKPiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBH b29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK