From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH hwc v2 16/18] drm_hwcomposer: Find writeback connector for scene flattening Date: Tue, 17 Apr 2018 13:15:59 -0400 Message-ID: <20180417171559.GL73214@art_vandelay> References: <1523460149-1740-1-git-send-email-alexandru-cosmin.gheorghe@arm.com> <1523460149-1740-17-git-send-email-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-x243.google.com (mail-yw0-x243.google.com [IPv6:2607:f8b0:4002:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47B9E6E142 for ; Tue, 17 Apr 2018 17:16:02 +0000 (UTC) Received: by mail-yw0-x243.google.com with SMTP id 199so883127ywd.9 for ; Tue, 17 Apr 2018 10:16:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1523460149-1740-17-git-send-email-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru Gheorghe Cc: ayan.halder@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMTEsIDIwMTggYXQgMDQ6MjI6MjdQTSArMDEwMCwgQWxleGFuZHJ1IEdoZW9y Z2hlIHdyb3RlOgo+IEFkZCBsb2dpYyBmb3IgZmluZGluZyBhIHN1aXRhYmxlIHdyaXRlYmFjayBj b25uZWN0b3IsIHRoZXJlIGFyZSB0d28KPiBwb3NzaWJpbGl0aWVzIGZvciBmaW5kaW5nIGFuIHVz YWJsZSB3cml0ZWJhY2sgY29ubmVjdG9yOgo+IAo+IDEpIEF0dGFjaGVkIHRvIHRoZSBzYW1lIENS VEMgYXMgdGhlIGRpc3BsYXkgYW5kIGNhbiBmdW5jdGlvbgo+ICAgIGNvbmN1cnJlbnRseSB3aXRo IHRoZSBkaXNwbGF5IGNvbm5lY3Rvci4KPiAKPiAyKSBPbiBhIGRpZmZlcmVudCBDUlRDIGFuZCB0 aGUgZGlzcGxheSBjb25uZWN0b3IgaXMgbm90IHVzZWQgKHN0YXRlICE9Cj4gRFJNX01PREVfQ09O TkVDVEVEKS4gV2hhdCdzIG5vdCBoYW5kbGVkIGhlcmUgYW5kIHNob3VsZCBiZSBoYW5kbGUgaXMK PiB3aGF0IGhhcHBlbnMgaWYgY29ubmVjdG9yIGNoYW5nZXMgc3RhdGUgd2hpbGUgZmxhdHRlbmlu ZywgYnV0IHNpbmNlCj4gaG90cGx1ZyBpcyBub3Qgd2lyZWQgeWV0LCBpdCdzIG5vdCBzb21ldGhp bmcgd2Ugc2hvdWxkIHdvcnJ5IGFib3V0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFsZXhhbmRydSBH aGVvcmdoZSA8YWxleGFuZHJ1LWNvc21pbi5naGVvcmdoZUBhcm0uY29tPgo+IC0tLQo+ICBkcm1y ZXNvdXJjZXMuY3BwICAgIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBkcm1yZXNv dXJjZXMuaCAgICAgIHwgIDIgKy0KPiAgcmVzb3VyY2VtYW5hZ2VyLmNwcCB8IDI0ICsrKysrKysr KysrKysrKysrKysrKysrKwo+ICByZXNvdXJjZW1hbmFnZXIuaCAgIHwgIDEgKwo+ICA0IGZpbGVz IGNoYW5nZWQsIDUxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJtcmVzb3VyY2VzLmNwcCBiL2RybXJlc291cmNlcy5jcHAKPiBpbmRleCBmZWY2ODM1Li43 MDEyNmE0IDEwMDY0NAo+IC0tLSBhL2RybXJlc291cmNlcy5jcHAKPiArKysgYi9kcm1yZXNvdXJj ZXMuY3BwCj4gQEAgLTI2OSw2ICsyNjksMzEgQEAgRHJtQ29ubmVjdG9yICpEcm1SZXNvdXJjZXM6 OkdldFdyaXRlYmFja0Nvbm5lY3RvckZvckRpc3BsYXkoaW50IGRpc3BsYXkpIGNvbnN0IHsKPiAg ICByZXR1cm4gTlVMTDsKPiAgfQo+ICAKPiArLy8gVE9ETyB3aGF0IGhhcHBlbnMgd2hlbiBob3Rw bHVnZ2luZwo+ICtEcm1Db25uZWN0b3IgKkRybVJlc291cmNlczo6QXZhaWxhYmxlV3JpdGViYWNr Q29ubmVjdG9yKGludCBkaXNwbGF5KSBjb25zdCB7Cj4gKyAgRHJtQ29ubmVjdG9yICp3cml0ZWJh Y2tfY29ubiA9IEdldFdyaXRlYmFja0Nvbm5lY3RvckZvckRpc3BsYXkoZGlzcGxheSk7Cj4gKyAg RHJtQ29ubmVjdG9yICpkaXNwbGF5X2Nvbm4gPSBHZXRDb25uZWN0b3JGb3JEaXNwbGF5KGRpc3Bs YXkpOwo+ICsgIC8vIElmIHdlIGhhdmUgYSB3cml0ZWJhY2sgYWxyZWFkeSBhdHRhY2hlZCB0byB0 aGUgc2FtZSBDUlRDLCBqdXN0IHVzZSB0aGF0LCBpZgo+ICsgIC8vIHBvc3NpYmxlCj4gKyAgaWYg KGRpc3BsYXlfY29ubiAmJiB3cml0ZWJhY2tfY29ubiAmJgo+ICsgICAgICB3cml0ZWJhY2tfY29u bi0+ZW5jb2RlcigpLT5jYW5fY2xvbmUoZGlzcGxheV9jb25uLT5lbmNvZGVyKCkpKQo+ICsgICAg cmV0dXJuIHdyaXRlYmFja19jb25uOwo+ICsKPiArICAvLyBVc2UgYW5vdGhlciBDUlRDIGlmIGF2 YWlsYWJsZSBhbmQgZG9lc24ndCBoYXZlIGFueSBjb25uZWN0b3IKPiArICBmb3IgKGF1dG8gJmNy dGMgOiBjcnRjc18pIHsKPiArICAgIGlmIChjcnRjLT5kaXNwbGF5KCkgPT0gZGlzcGxheSkKPiAr ICAgICAgY29udGludWU7Cj4gKyAgICBkaXNwbGF5X2Nvbm4gPSBHZXRDb25uZWN0b3JGb3JEaXNw bGF5KGNydGMtPmRpc3BsYXkoKSk7Cj4gKyAgICAvLyBJZiB3ZSBoYXZlIGEgZGlzcGxheSBjb25u ZWN0ZWQgZG9uJ3QgdXNlIGl0IGZvciB3cml0ZWJhY2sKPiArICAgIGlmIChkaXNwbGF5X2Nvbm4g JiYgZGlzcGxheV9jb25uLT5zdGF0ZSgpID09IERSTV9NT0RFX0NPTk5FQ1RFRCkKPiArICAgICAg Y29udGludWU7Cj4gKyAgICB3cml0ZWJhY2tfY29ubiA9IEdldFdyaXRlYmFja0Nvbm5lY3RvckZv ckRpc3BsYXkoY3J0Yy0+ZGlzcGxheSgpKTsKPiArICAgIGlmICh3cml0ZWJhY2tfY29ubikKPiAr ICAgICAgcmV0dXJuIHdyaXRlYmFja19jb25uOwo+ICsgIH0KPiArICByZXR1cm4gTlVMTDsKPiAr fQo+ICsKPiAgRHJtQ3J0YyAqRHJtUmVzb3VyY2VzOjpHZXRDcnRjRm9yRGlzcGxheShpbnQgZGlz cGxheSkgY29uc3Qgewo+ICAgIGZvciAoYXV0byAmY3J0YyA6IGNydGNzXykgewo+ICAgICAgaWYg KGNydGMtPmRpc3BsYXkoKSA9PSBkaXNwbGF5KQo+IGRpZmYgLS1naXQgYS9kcm1yZXNvdXJjZXMu aCBiL2RybXJlc291cmNlcy5oCj4gaW5kZXggNGZiMTdmYy4uOTE3NmI4ZSAxMDA2NDQKPiAtLS0g YS9kcm1yZXNvdXJjZXMuaAo+ICsrKyBiL2RybXJlc291cmNlcy5oCj4gQEAgLTYwLDcgKzYwLDcg QEAgY2xhc3MgRHJtUmVzb3VyY2VzIHsKPiAgCj4gICAgRHJtQ29ubmVjdG9yICpHZXRDb25uZWN0 b3JGb3JEaXNwbGF5KGludCBkaXNwbGF5KSBjb25zdDsKPiAgICBEcm1Db25uZWN0b3IgKkdldFdy aXRlYmFja0Nvbm5lY3RvckZvckRpc3BsYXkoaW50IGRpc3BsYXkpIGNvbnN0Owo+IC0gIERybUNv bm5lY3RvciAqRmluZFdyaXRlYmFja0Nvbm5lY3RvcihpbnQgZGlzcGxheSkgY29uc3Q7CgpXaGF0 J3MgdXAgd2l0aCB0aGlzPwoKPiArICBEcm1Db25uZWN0b3IgKkF2YWlsYWJsZVdyaXRlYmFja0Nv bm5lY3RvcihpbnQgZGlzcGxheSkgY29uc3Q7Cj4gICAgRHJtQ3J0YyAqR2V0Q3J0Y0ZvckRpc3Bs YXkoaW50IGRpc3BsYXkpIGNvbnN0Owo+ICAgIERybVBsYW5lICpHZXRQbGFuZSh1aW50MzJfdCBp ZCkgY29uc3Q7Cj4gICAgRHJtRXZlbnRMaXN0ZW5lciAqZXZlbnRfbGlzdGVuZXIoKTsKPiBkaWZm IC0tZ2l0IGEvcmVzb3VyY2VtYW5hZ2VyLmNwcCBiL3Jlc291cmNlbWFuYWdlci5jcHAKPiBpbmRl eCBlN2I2NTRlLi5iMmE0NDU4IDEwMDY0NAo+IC0tLSBhL3Jlc291cmNlbWFuYWdlci5jcHAKPiAr KysgYi9yZXNvdXJjZW1hbmFnZXIuY3BwCj4gQEAgLTQ5LDYgKzQ5LDMwIEBAIGludCBSZXNvdXJj ZU1hbmFnZXI6OkluaXQoKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnN0IGh3X21v ZHVsZV90ICoqKSZncmFsbG9jXyk7Cj4gIH0KPiAgCj4gK0RybUNvbm5lY3RvciAqUmVzb3VyY2VN YW5hZ2VyOjpBdmFpbGFibGVXcml0ZWJhY2tDb25uZWN0b3IoaW50IGRpc3BsYXkpIHsKPiArICBE cm1SZXNvdXJjZXMgKmRybV9yZXNvdXJjZSA9IEdldERybVJlc291cmNlcyhkaXNwbGF5KTsKPiAr ICBEcm1Db25uZWN0b3IgKndyaXRlYmFja19jb25uID0gTlVMTDsKPiArICBpZiAoZHJtX3Jlc291 cmNlKSB7Cj4gKyAgICB3cml0ZWJhY2tfY29ubiA9IGRybV9yZXNvdXJjZS0+QXZhaWxhYmxlV3Jp dGViYWNrQ29ubmVjdG9yKGRpc3BsYXkpOwo+ICsgICAgaWYgKHdyaXRlYmFja19jb25uKSB7Cj4g KyAgICAgIEFMT0dJKCJVc2Ugd3JpdGViYWNrIGNvbm5lY3RlZCB0byBkaXNwbGF5ICVkXG4iLAo+ ICsgICAgICAgICAgICB3cml0ZWJhY2tfY29ubi0+ZGlzcGxheSgpKTsKClRoaXMgc2VlbXMgYSBs aXR0bGUgY2hhdHR5LCBpdCdzIHdyaXR0ZW4gZXZlcnkgZmxhdHRlbiwgeWVhaD8KCj4gKyAgICAg IHJldHVybiB3cml0ZWJhY2tfY29ubjsKPiArICAgIH0KPiArICB9Cj4gKyAgZm9yIChhdXRvICZk cm0gOiBkcm1zXykgewo+ICsgICAgaWYgKGRybS5nZXQoKSA9PSBkcm1fcmVzb3VyY2UpCj4gKyAg ICAgIGNvbnRpbnVlOwo+ICsgICAgd3JpdGViYWNrX2Nvbm4gPSBkcm0tPkF2YWlsYWJsZVdyaXRl YmFja0Nvbm5lY3RvcihkaXNwbGF5KTsKPiArICAgIGlmICh3cml0ZWJhY2tfY29ubikgewo+ICsg ICAgICBBTE9HSSgiVXNlIHdyaXRlYmFjayBjb25uZWN0ZWQgdG8gZGlzcGxheSAlZFxuIiwKPiAr ICAgICAgICAgICAgd3JpdGViYWNrX2Nvbm4tPmRpc3BsYXkoKSk7Cj4gKyAgICAgIHJldHVybiB3 cml0ZWJhY2tfY29ubjsKPiArICAgIH0KPiArICB9Cj4gKyAgcmV0dXJuIHdyaXRlYmFja19jb25u Owo+ICt9Cj4gKwo+ICBEcm1SZXNvdXJjZXMgKlJlc291cmNlTWFuYWdlcjo6R2V0RHJtUmVzb3Vy Y2VzKGludCBkaXNwbGF5KSB7Cj4gICAgZm9yICh1aW50MzJfdCBpID0gMDsgaSA8IGRybXNfLnNp emUoKTsgaSsrKSB7Cj4gICAgICBpZiAoZHJtc19baV0tPkhhbmRsZXNEaXNwbGF5KGRpc3BsYXkp KQo+IGRpZmYgLS1naXQgYS9yZXNvdXJjZW1hbmFnZXIuaCBiL3Jlc291cmNlbWFuYWdlci5oCj4g aW5kZXggYjhjYWE5YS4uNTdmN2EyYSAxMDA2NDQKPiAtLS0gYS9yZXNvdXJjZW1hbmFnZXIuaAo+ ICsrKyBiL3Jlc291cmNlbWFuYWdlci5oCj4gQEAgLTE4LDYgKzE4LDcgQEAgY2xhc3MgUmVzb3Vy Y2VNYW5hZ2VyIHsKPiAgICBEcm1SZXNvdXJjZXMgKkdldERybVJlc291cmNlcyhpbnQgZGlzcGxh eSk7Cj4gICAgc3RkOjpzaGFyZWRfcHRyPEltcG9ydGVyPiBHZXRJbXBvcnRlcihpbnQgZGlzcGxh eSk7Cj4gICAgY29uc3QgZ3JhbGxvY19tb2R1bGVfdCAqR2V0R3JhbGxvYygpOwo+ICsgIERybUNv bm5lY3RvciAqQXZhaWxhYmxlV3JpdGViYWNrQ29ubmVjdG9yKGludCBkaXNwbGF5KTsKPiAgCj4g ICBwcml2YXRlOgo+ICAgIHN0ZDo6dmVjdG9yPHN0ZDo6dW5pcXVlX3B0cjxEcm1SZXNvdXJjZXM+ PiBkcm1zXzsKPiAtLSAKPiAyLjcuNAo+IAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5l ZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=