From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbeDRRrY (ORCPT ); Wed, 18 Apr 2018 13:47:24 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46060 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbeDRRrX (ORCPT ); Wed, 18 Apr 2018 13:47:23 -0400 Date: Wed, 18 Apr 2018 13:47:21 -0400 (EDT) Message-Id: <20180418.134721.283381724211219025.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: mpatocka@redhat.com, edumazet@google.com, joby.poriyath@citrix.com, bhutchings@solarflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] net: don't use kvzalloc for DMA memory From: David Miller In-Reply-To: <5f4e1286-b79f-0b9f-9a30-47d7654f3889@gmail.com> References: <3e65977e-53cd-bf09-bc4b-0ce40e9091fe@gmail.com> <5f4e1286-b79f-0b9f-9a30-47d7654f3889@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Wed, 18 Apr 2018 09:51:25 -0700 > I suggest that virtio_net clearly identifies which part needs a specific allocation > and does its itself, instead of abusing the netdev_priv storage. > > Ie use a pointer to a block of memory, allocated by virtio_net, for virtio_net. +1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: don't use kvzalloc for DMA memory Date: Wed, 18 Apr 2018 13:47:21 -0400 (EDT) Message-ID: <20180418.134721.283381724211219025.davem@davemloft.net> References: <3e65977e-53cd-bf09-bc4b-0ce40e9091fe@gmail.com> <5f4e1286-b79f-0b9f-9a30-47d7654f3889@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, edumazet@google.com, mpatocka@redhat.com, joby.poriyath@citrix.com, bhutchings@solarflare.com To: eric.dumazet@gmail.com Return-path: In-Reply-To: <5f4e1286-b79f-0b9f-9a30-47d7654f3889@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Eric Dumazet Date: Wed, 18 Apr 2018 09:51:25 -0700 > I suggest that virtio_net clearly identifies which part needs a specific allocation > and does its itself, instead of abusing the netdev_priv storage. > > Ie use a pointer to a block of memory, allocated by virtio_net, for virtio_net. +1