From: Stefan Hajnoczi <stefanha@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, jhansen@vmware.com
Subject: Re: [PATCH] VSOCK: make af_vsock.ko removable again
Date: Wed, 18 Apr 2018 12:14:51 +0800 [thread overview]
Message-ID: <20180418041451.GB25649@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180417.094512.321362741144442657.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On Tue, Apr 17, 2018 at 09:45:12AM -0400, David Miller wrote:
> From: Stefan Hajnoczi <stefanha@redhat.com>
> Date: Tue, 17 Apr 2018 14:25:58 +0800
>
> > Commit c1eef220c1760762753b602c382127bfccee226d ("vsock: always call
> > vsock_init_tables()") introduced a module_init() function without a
> > corresponding module_exit() function.
> >
> > Modules with an init function can only be removed if they also have an
> > exit function. Therefore the vsock module was considered "permanent"
> > and could not be removed.
> >
> > This patch adds an empty module_exit() function so that "rmmod vsock"
> > works. No explicit cleanup is required because:
> >
> > 1. Transports call vsock_core_exit() upon exit and cannot be removed
> > while sockets are still alive.
> > 2. vsock_diag.ko does not perform any action that requires cleanup by
> > vsock.ko.
> >
> > Reported-by: Xiumei Mu <xmu@redhat.com>
> > Cc: Cong Wang <xiyou.wangcong@gmail.com>
> > Cc: Jorgen Hansen <jhansen@vmware.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Applied, but please provide a proper Fixes: tag next time. I added it
> for you this time.
Will do. Thanks!
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2018-04-18 4:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 6:25 [PATCH] VSOCK: make af_vsock.ko removable again Stefan Hajnoczi
2018-04-17 8:30 ` Jorgen S. Hansen
2018-04-17 13:45 ` David Miller
2018-04-18 4:14 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418041451.GB25649@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=davem@davemloft.net \
--cc=jhansen@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.