From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks Date: Wed, 18 Apr 2018 09:54:26 +0200 Message-ID: <20180418095426.08ca87ec.cohuck@redhat.com> References: <1523991487-241006-1-git-send-email-mst@redhat.com> <1523991487-241006-2-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Wanpeng Li , Brijesh Singh , Eduardo Habkost , kvm@vger.kernel.org, Radim =?UTF-8?B?S3LEjW3DocWZ?= , qemu-devel@nongnu.org, Roman Kagan , Paolo Bonzini , Gerd Hoffmann To: "Michael S. Tsirkin" Return-path: In-Reply-To: <1523991487-241006-2-git-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On Tue, 17 Apr 2018 21:58:21 +0300 "Michael S. Tsirkin" wrote: > It turns out (as will be clear from follow-up patches) > we do not really need any kvm para macros host side > for now, except on x86, and there we need it > unconditionally whether we run on kvm or we don't. > > Import the x86 asm/kvm_para.h into standard-headers, > follow-up patches remove a bunch of code using this. > > Signed-off-by: Michael S. Tsirkin > --- > scripts/update-linux-headers.sh | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh > index 5b1d8dc..a017b53 100755 > --- a/scripts/update-linux-headers.sh > +++ b/scripts/update-linux-headers.sh > @@ -43,6 +43,7 @@ cp_portable() { > -e 'limits' \ > -e 'linux/kernel' \ > -e 'linux/sysinfo' \ > + -e 'asm-generic/kvm_para' \ > > /dev/null > then > echo "Unexpected #include in input file $f". > @@ -98,13 +99,9 @@ for arch in $ARCHLIST; do > > rm -rf "$output/linux-headers/asm-$arch" > mkdir -p "$output/linux-headers/asm-$arch" > - for header in kvm.h kvm_para.h unistd.h; do > + for header in kvm.h unistd.h; do > cp "$tmpdir/include/asm/$header" "$output/linux-headers/asm-$arch" > done > - if [ $arch = powerpc ]; then > - cp "$tmpdir/include/asm/epapr_hcalls.h" "$output/linux-headers/asm-powerpc/" > - fi Hm, why are you dropping this one? (The other changes look sane.) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8hvS-0007Km-MT for qemu-devel@nongnu.org; Wed, 18 Apr 2018 03:54:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8hvP-0004u6-M3 for qemu-devel@nongnu.org; Wed, 18 Apr 2018 03:54:46 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44796 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8hvP-0004th-HC for qemu-devel@nongnu.org; Wed, 18 Apr 2018 03:54:43 -0400 Date: Wed, 18 Apr 2018 09:54:26 +0200 From: Cornelia Huck Message-ID: <20180418095426.08ca87ec.cohuck@redhat.com> In-Reply-To: <1523991487-241006-2-git-send-email-mst@redhat.com> References: <1523991487-241006-1-git-send-email-mst@redhat.com> <1523991487-241006-2-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Wanpeng Li , kvm@vger.kernel.org, Paolo Bonzini , Radim =?UTF-8?B?S3LEjW3DocWZ?= , Eduardo Habkost , Roman Kagan , Brijesh Singh , Gerd Hoffmann On Tue, 17 Apr 2018 21:58:21 +0300 "Michael S. Tsirkin" wrote: > It turns out (as will be clear from follow-up patches) > we do not really need any kvm para macros host side > for now, except on x86, and there we need it > unconditionally whether we run on kvm or we don't. > > Import the x86 asm/kvm_para.h into standard-headers, > follow-up patches remove a bunch of code using this. > > Signed-off-by: Michael S. Tsirkin > --- > scripts/update-linux-headers.sh | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh > index 5b1d8dc..a017b53 100755 > --- a/scripts/update-linux-headers.sh > +++ b/scripts/update-linux-headers.sh > @@ -43,6 +43,7 @@ cp_portable() { > -e 'limits' \ > -e 'linux/kernel' \ > -e 'linux/sysinfo' \ > + -e 'asm-generic/kvm_para' \ > > /dev/null > then > echo "Unexpected #include in input file $f". > @@ -98,13 +99,9 @@ for arch in $ARCHLIST; do > > rm -rf "$output/linux-headers/asm-$arch" > mkdir -p "$output/linux-headers/asm-$arch" > - for header in kvm.h kvm_para.h unistd.h; do > + for header in kvm.h unistd.h; do > cp "$tmpdir/include/asm/$header" "$output/linux-headers/asm-$arch" > done > - if [ $arch = powerpc ]; then > - cp "$tmpdir/include/asm/epapr_hcalls.h" "$output/linux-headers/asm-powerpc/" > - fi Hm, why are you dropping this one? (The other changes look sane.)