From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device Date: Wed, 18 Apr 2018 10:36:42 -0700 Message-ID: <20180418103642.0d640375@xeon-e3> References: <20180417215324.8576-1-sthemmin@microsoft.com> <20180417215324.8576-3-sthemmin@microsoft.com> <438086f5-76f4-3c72-5c2f-b54577d12af2@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Stephen Hemminger To: Ferruh Yigit Return-path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id CFE555F25 for ; Wed, 18 Apr 2018 19:36:45 +0200 (CEST) Received: by mail-pf0-f180.google.com with SMTP id j5so1258261pfh.2 for ; Wed, 18 Apr 2018 10:36:45 -0700 (PDT) In-Reply-To: <438086f5-76f4-3c72-5c2f-b54577d12af2@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 18 Apr 2018 14:19:52 +0100 Ferruh Yigit wrote: > > +/* enables testpmd to collect per queue stats. */ > > +static int > > +hn_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *eth_dev, > > + __rte_unused uint16_t queue_id, > > + __rte_unused uint8_t stat_idx, > > + __rte_unused uint8_t is_rx) > > +{ > > + return 0; > > +} > > IS this dev_ops needed at all? This is leftover. It is clone of original from virtio. Not sure why (or if) it is needed. Will drop and see.