From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next] team: account for oper state Date: Wed, 18 Apr 2018 14:56:44 +0200 Message-ID: <20180418125644.GD1989@nanopsycho> References: <20180418102950.1033-1-gwilkie@vyatta.att-mail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: George Wilkie Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:43927 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753651AbeDRM4p (ORCPT ); Wed, 18 Apr 2018 08:56:45 -0400 Received: by mail-wr0-f195.google.com with SMTP id u4-v6so4544626wrg.10 for ; Wed, 18 Apr 2018 05:56:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180418102950.1033-1-gwilkie@vyatta.att-mail.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Apr 18, 2018 at 12:29:50PM CEST, gwilkie@vyatta.att-mail.com wrote: >Account for operational state when determining port linkup state, >as per Documentation/networking/operstates.txt. Could you please point me to the exact place in the document where this is suggested? > >Signed-off-by: George Wilkie >--- > drivers/net/team/team.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c >index a6c6ce19eeee..231264a05e55 100644 >--- a/drivers/net/team/team.c >+++ b/drivers/net/team/team.c >@@ -2918,7 +2918,8 @@ static int team_device_event(struct notifier_block *unused, > case NETDEV_CHANGE: > if (netif_running(port->dev)) > team_port_change_check(port, >- !!netif_carrier_ok(port->dev)); >+ !!(netif_carrier_ok(port->dev) && >+ netif_oper_up(port->dev))); > break; > case NETDEV_UNREGISTER: > team_del_slave(port->team->dev, dev); >-- >2.11.0 >