From: Herbert Xu <herbert@gondor.apana.org.au>
To: NeilBrown <neilb@suse.com>
Cc: Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()
Date: Thu, 19 Apr 2018 11:22:37 +0800 [thread overview]
Message-ID: <20180419032237.yjvjuh6n7n6tggtr@gondor.apana.org.au> (raw)
In-Reply-To: <87efjcqg2r.fsf@notabene.neil.brown.name>
On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote:
>
> I don't want to do that - I just want the documentation to be correct
> (or at least, not be blatantly incorrect). The function does not sleep,
> and is safe to call with spin locks held.
> Do we need to spell out when it can be called? If so, maybe:
>
> This function may be called from any process context, including
> non-preemptable context, but cannot be called from interrupts.
Just to make it perfectly clear, how about "cannot be called from
softirq or hardirq context"? Previously the not able to sleep part
completely ruled out any ambiguity but the new wording could confuse
people into thinking that this can be called from softirq context
where it would be unsafe if mixed with process context usage.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-04-19 3:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 6:47 [PATCH 0/6] Assorted rhashtable improvements. RESEND NeilBrown
2018-04-18 6:47 ` [PATCH 3/6] rhashtable: reset iter when rhashtable_walk_start sees new table NeilBrown
2018-04-18 6:47 ` [PATCH 1/6] rhashtable: remove outdated comments about grow_decision etc NeilBrown
2018-04-18 14:29 ` Herbert Xu
2018-04-18 23:09 ` NeilBrown
2018-04-19 1:47 ` David Miller
2018-04-23 1:41 ` NeilBrown
2018-04-18 6:47 ` [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter() NeilBrown
2018-04-18 14:28 ` Herbert Xu
2018-04-18 22:56 ` NeilBrown
2018-04-19 3:22 ` Herbert Xu [this message]
2018-04-23 1:39 ` NeilBrown
2018-04-23 8:06 ` Herbert Xu
2018-04-18 6:47 ` [PATCH 6/6] rhashtable: add rhashtable_walk_prev() NeilBrown
2018-04-18 14:35 ` Herbert Xu
2018-04-18 23:08 ` NeilBrown
2018-04-23 8:07 ` Herbert Xu
2018-04-18 6:47 ` [PATCH 4/6] rhashtable: improve rhashtable_walk stability when stop/start used NeilBrown
2018-04-18 6:47 ` [PATCH 5/6] rhashtable: further improve stability of rhashtable_walk NeilBrown
-- strict thread matches above, loose matches on Subject: below --
2018-04-18 6:47 [PATCH 0/6] Assorted rhashtable improvements NeilBrown
2018-04-18 6:47 ` [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter() NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419032237.yjvjuh6n7n6tggtr@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.