From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Duszynski Subject: Re: [PATCH 0/2] add MRVL MVPP2 PMD to meson Date: Thu, 19 Apr 2018 10:55:33 +0200 Message-ID: <20180419085533.GA8060@sh> References: <1523447107-13324-1-git-send-email-tdu@semihalf.com> <20180413161219.GB37024@bricha3-MOBL.ger.corp.intel.com> <20180418150229.GA127664@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Tomasz Duszynski , dev@dpdk.org, jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com, jianbo.liu@arm.com, pablo.de.lara.guarch@intel.com To: Bruce Richardson Return-path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id BBB027F70 for ; Thu, 19 Apr 2018 10:55:35 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id q5-v6so6628023lff.12 for ; Thu, 19 Apr 2018 01:55:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180418150229.GA127664@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 18, 2018 at 04:02:30PM +0100, Bruce Richardson wrote: > On Fri, Apr 13, 2018 at 05:12:19PM +0100, Bruce Richardson wrote: > > On Wed, Apr 11, 2018 at 01:45:05PM +0200, Tomasz Duszynski wrote: > > > This patchseries adds MRVL MVPP2 PMD to meson build system. > > > > > > Tomasz Duszynski (2): > > > net/mvpp2: rename the version file to standard > > > net/mvpp2: add meson build file > > > > > > > The patches look ok to me as far as the meson code is concerned, but I = have > > no way to test compilation etc. It doesn't cause issues with other x86 = or > > arm builds though, so: > > > > Series Acked-by: Bruce Richardson > > +Pablo, who is looking at the crypto driver which is similar. > > I've just realised at this stage - while looking at something similar with > the turbo_sw baseband driver - that the use of environmental variables is > probably going to cause us problems down the line here. In the case of > cross-compilation, the meson build is going to pull the environment > variable of the host, and use that, even in cases where there is no > cross-compile library available. > > I think that for cases like this, using a build option is a better > solution. It explicitly can be set for each independent build, avoiding t= he > cross-build issues I refer to, and also prevents us having issues with > changing the path in the environment and meson not recognising the change > (environment variables are not tracked for reconfigure, unlike options). > > So, would you be ok with changing this to take the MUSDK path from a meson > option rather than the environment? > > /Bruce I am okay with the proposed change. As for crypto patch I'll prepare v2. -- - Tomasz Duszy=C5=84ski