* [PATCH net-next v2] team: account for oper state
@ 2018-04-19 10:24 George Wilkie
2018-04-19 10:28 ` George Wilkie
0 siblings, 1 reply; 2+ messages in thread
From: George Wilkie @ 2018-04-19 10:24 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev
Account for operational state when determining port linkup state,
as per Documentation/networking/operstates.txt.
Signed-off-by: George Wilkie <gwilkie@vyatta.att-mail.com>
---
drivers/net/team/team.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index a6c6ce19eeee..ed4d109f40f3 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2918,7 +2918,7 @@ static int team_device_event(struct notifier_block *unused,
case NETDEV_CHANGE:
if (netif_running(port->dev))
team_port_change_check(port,
- !!netif_carrier_ok(port->dev));
+ !!(netif_oper_up(port->dev)));
break;
case NETDEV_UNREGISTER:
team_del_slave(port->team->dev, dev);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] team: account for oper state
2018-04-19 10:24 [PATCH net-next v2] team: account for oper state George Wilkie
@ 2018-04-19 10:28 ` George Wilkie
0 siblings, 0 replies; 2+ messages in thread
From: George Wilkie @ 2018-04-19 10:28 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev
On Thu, Apr 19, 2018 at 11:24:15AM +0100, George Wilkie wrote:
> Account for operational state when determining port linkup state,
> as per Documentation/networking/operstates.txt.
>
> Signed-off-by: George Wilkie <gwilkie@vyatta.att-mail.com>
> ---
> drivers/net/team/team.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
> index a6c6ce19eeee..ed4d109f40f3 100644
> --- a/drivers/net/team/team.c
> +++ b/drivers/net/team/team.c
> @@ -2918,7 +2918,7 @@ static int team_device_event(struct notifier_block *unused,
> case NETDEV_CHANGE:
> if (netif_running(port->dev))
> team_port_change_check(port,
> - !!netif_carrier_ok(port->dev));
> + !!(netif_oper_up(port->dev)));
Bah, forgot to remove the extra ().
> break;
> case NETDEV_UNREGISTER:
> team_del_slave(port->team->dev, dev);
> --
> 2.11.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-19 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 10:24 [PATCH net-next v2] team: account for oper state George Wilkie
2018-04-19 10:28 ` George Wilkie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.