From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Alexander Popov <alex.popov@linux.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
sil2review@lists.osadl.org, Dmitry Vyukov <dvyukov@google.com>,
syzkaller@googlegroups.com
Subject: Re: [v2 1/1] i2c: dev: prevent ZERO_SIZE_PTR deref in i2cdev_ioctl_rdwr()
Date: Thu, 19 Apr 2018 15:49:02 +0200 [thread overview]
Message-ID: <20180419134902.6l5jsf4wpqfiaskj@pengutronix.de> (raw)
In-Reply-To: <1524140962-25639-1-git-send-email-alex.popov@linux.com>
On Thu, Apr 19, 2018 at 03:29:22PM +0300, Alexander Popov wrote:
> i2cdev_ioctl_rdwr() allocates i2c_msg.buf using memdup_user(), which
> returns ZERO_SIZE_PTR if i2c_msg.len is zero.
>
> Currently i2cdev_ioctl_rdwr() always dereferences the buf pointer in case
> of I2C_M_RD | I2C_M_RECV_LEN transfer. That causes a kernel oops in
> case of zero len.
>
> Let's check the len against zero before dereferencing buf pointer.
>
> This issue was triggered by syzkaller.
>
> Signed-off-by: Alexander Popov <alex.popov@linux.com>
> ---
> drivers/i2c/i2c-dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index 036a03f..5790bc8 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -280,6 +280,7 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client,
> */
> if (msgs[i].flags & I2C_M_RECV_LEN) {
> if (!(msgs[i].flags & I2C_M_RD) ||
> + !msgs[i].len ||
I'd prefer
msgs[i].len > 0
here instead of
!msgs[i].len
because I can parse that more easily. Semantically the patch is fine and
can have my
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> msgs[i].buf[0] < 1 ||
> msgs[i].len < msgs[i].buf[0] +
> I2C_SMBUS_BLOCK_MAX) {
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-04-19 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 12:29 [v2 1/1] i2c: dev: prevent ZERO_SIZE_PTR deref in i2cdev_ioctl_rdwr() Alexander Popov
2018-04-19 13:49 ` Uwe Kleine-König [this message]
2018-04-19 17:01 ` Alexander Popov
2018-04-20 5:58 ` Uwe Kleine-König
2018-04-23 20:18 ` Alexander Popov
2018-04-27 12:06 ` Wolfram Sang
2018-04-30 7:13 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419134902.6l5jsf4wpqfiaskj@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alex.popov@linux.com \
--cc=dvyukov@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sil2review@lists.osadl.org \
--cc=syzkaller@googlegroups.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.