From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [RFC PATCH v2 4/4] acpi: apei: Warn when GHES marks correctable errors as "fatal" Date: Thu, 19 Apr 2018 17:46:56 +0200 Message-ID: <20180419154656.GF3600@pd.tnic> References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180416215903.7318-5-mr.nuke.me@gmail.com> <20180418175452.GK4795@pd.tnic> <807002b1-ccb9-22c8-6563-ade7e44912ff@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <807002b1-ccb9-22c8-6563-ade7e44912ff@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: "Alex G." Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-Id: linux-acpi@vger.kernel.org On Thu, Apr 19, 2018 at 10:11:03AM -0500, Alex G. wrote: > There is value in this. From my observations, fw claims it will do > everything through FFS, yet fails to fully handle the situation. It's > rooted in FW's assumptions about OS behavior. Because the (old) versions > of windows, esxi, and rhel used during development crash, fw assumes > that _all_ OSes crash. The result in a surprising majority of cases is > that FFS doesn't properly handle recurring errors, and fw is, in fact, > broken. So FW being broken is a social secret. But we don't care. We have tried, nothing happens. No one moves. The crack monkeys which program it have long moved to the next release and you hear crap like, "we don't support linux" and other bullshit. What we do now is to try to make the best of it - we either can handle an error *without* firmware's help or we panic. If we can recover from it, let's do that without screaming about something the user can't deal with anyway. All those FW_ERR printks cause nothing but expensive support calls, the outcome of which is nothing. Just a lot of money down the drain. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v2,4/4] acpi: apei: Warn when GHES marks correctable errors as "fatal" From: Borislav Petkov Message-Id: <20180419154656.GF3600@pd.tnic> Date: Thu, 19 Apr 2018 17:46:56 +0200 To: "Alex G." Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-ID: T24gVGh1LCBBcHIgMTksIDIwMTggYXQgMTA6MTE6MDNBTSAtMDUwMCwgQWxleCBHLiB3cm90ZToK PiBUaGVyZSBpcyB2YWx1ZSBpbiB0aGlzLiBGcm9tIG15IG9ic2VydmF0aW9ucywgZncgY2xhaW1z IGl0IHdpbGwgZG8KPiBldmVyeXRoaW5nIHRocm91Z2ggRkZTLCB5ZXQgZmFpbHMgdG8gZnVsbHkg aGFuZGxlIHRoZSBzaXR1YXRpb24uIEl0J3MKPiByb290ZWQgaW4gRlcncyBhc3N1bXB0aW9ucyBh Ym91dCBPUyBiZWhhdmlvci4gQmVjYXVzZSB0aGUgKG9sZCkgdmVyc2lvbnMKPiBvZiB3aW5kb3dz LCBlc3hpLCBhbmQgcmhlbCB1c2VkIGR1cmluZyBkZXZlbG9wbWVudCBjcmFzaCwgZncgYXNzdW1l cwo+IHRoYXQgX2FsbF8gT1NlcyBjcmFzaC4gVGhlIHJlc3VsdCBpbiBhIHN1cnByaXNpbmcgbWFq b3JpdHkgb2YgY2FzZXMgaXMKPiB0aGF0IEZGUyBkb2Vzbid0IHByb3Blcmx5IGhhbmRsZSByZWN1 cnJpbmcgZXJyb3JzLCBhbmQgZncgaXMsIGluIGZhY3QsCj4gYnJva2VuLgoKU28gRlcgYmVpbmcg YnJva2VuIGlzIGEgc29jaWFsIHNlY3JldC4gQnV0IHdlIGRvbid0IGNhcmUuIFdlIGhhdmUgdHJp ZWQsCm5vdGhpbmcgaGFwcGVucy4gTm8gb25lIG1vdmVzLiBUaGUgY3JhY2sgbW9ua2V5cyB3aGlj aCBwcm9ncmFtIGl0IGhhdmUKbG9uZyBtb3ZlZCB0byB0aGUgbmV4dCByZWxlYXNlIGFuZCB5b3Ug aGVhciBjcmFwIGxpa2UsICJ3ZSBkb24ndCBzdXBwb3J0CmxpbnV4IiBhbmQgb3RoZXIgYnVsbHNo aXQuCgpXaGF0IHdlIGRvIG5vdyBpcyB0byB0cnkgdG8gbWFrZSB0aGUgYmVzdCBvZiBpdCAtIHdl IGVpdGhlciBjYW4gaGFuZGxlCmFuIGVycm9yICp3aXRob3V0KiBmaXJtd2FyZSdzIGhlbHAgb3Ig d2UgcGFuaWMuIElmIHdlIGNhbiByZWNvdmVyIGZyb20KaXQsIGxldCdzIGRvIHRoYXQgd2l0aG91 dCBzY3JlYW1pbmcgYWJvdXQgc29tZXRoaW5nIHRoZSB1c2VyIGNhbid0IGRlYWwKd2l0aCBhbnl3 YXkuCgpBbGwgdGhvc2UgRldfRVJSIHByaW50a3MgY2F1c2Ugbm90aGluZyBidXQgZXhwZW5zaXZl IHN1cHBvcnQgY2FsbHMsIHRoZQpvdXRjb21lIG9mIHdoaWNoIGlzIG5vdGhpbmcuIEp1c3QgYSBs b3Qgb2YgbW9uZXkgZG93biB0aGUgZHJhaW4uCg==