From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [RFC PATCH v2 3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal. Date: Thu, 19 Apr 2018 18:45:28 +0200 Message-ID: <20180419164528.GD5635@pd.tnic> References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180416215903.7318-4-mr.nuke.me@gmail.com> <20180418175415.GJ4795@pd.tnic> <20180419154006.GE3600@pd.tnic> <977608e6-9f5d-c523-a78a-993ac5bfd55f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <977608e6-9f5d-c523-a78a-993ac5bfd55f@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: "Alex G." Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-Id: linux-acpi@vger.kernel.org On Thu, Apr 19, 2018 at 11:26:57AM -0500, Alex G. wrote: > At a very high level, I'm working with Dell on improving server > reliability, with a focus on NVME hotplug and surprise removal. One of > the features we don't support is surprise removal of NVME drives; > hotplug is supported with 'prepare to remove'. This is one of the > reasons NVME is not on feature parity with SAS and SATA. Ok, first question: is surprise removal something purely mechanical or do you need firmware support for it? In the sense that you need to tell the firmware that you will be removing the drive. I'm sceptical, though, as it has "surprise" in the name so I'm guessing the firmware doesn't know about it, the drive physically disappears and the FW starts spewing PCIe errors... > I'm not sure if this is the example you're looking for, but > take an r740xd server, and slowly unplug an Intel NVME drives at an > angle. You're likely to crash the machine. No no, that's actually a great example! Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v2,3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal. From: Borislav Petkov Message-Id: <20180419164528.GD5635@pd.tnic> Date: Thu, 19 Apr 2018 18:45:28 +0200 To: "Alex G." Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-ID: T24gVGh1LCBBcHIgMTksIDIwMTggYXQgMTE6MjY6NTdBTSAtMDUwMCwgQWxleCBHLiB3cm90ZToK PiBBdCBhIHZlcnkgaGlnaCBsZXZlbCwgSSdtIHdvcmtpbmcgd2l0aCBEZWxsIG9uIGltcHJvdmlu ZyBzZXJ2ZXIKPiByZWxpYWJpbGl0eSwgd2l0aCBhIGZvY3VzIG9uIE5WTUUgaG90cGx1ZyBhbmQg c3VycHJpc2UgcmVtb3ZhbC4gT25lIG9mCj4gdGhlIGZlYXR1cmVzIHdlIGRvbid0IHN1cHBvcnQg aXMgc3VycHJpc2UgcmVtb3ZhbCBvZiBOVk1FIGRyaXZlczsKPiBob3RwbHVnIGlzIHN1cHBvcnRl ZCB3aXRoICdwcmVwYXJlIHRvIHJlbW92ZScuIFRoaXMgaXMgb25lIG9mIHRoZQo+IHJlYXNvbnMg TlZNRSBpcyBub3Qgb24gZmVhdHVyZSBwYXJpdHkgd2l0aCBTQVMgYW5kIFNBVEEuCgpPaywgZmly c3QgcXVlc3Rpb246IGlzIHN1cnByaXNlIHJlbW92YWwgc29tZXRoaW5nIHB1cmVseSBtZWNoYW5p Y2FsIG9yCmRvIHlvdSBuZWVkIGZpcm13YXJlIHN1cHBvcnQgZm9yIGl0PyBJbiB0aGUgc2Vuc2Ug dGhhdCB5b3UgbmVlZCB0byB0ZWxsCnRoZSBmaXJtd2FyZSB0aGF0IHlvdSB3aWxsIGJlIHJlbW92 aW5nIHRoZSBkcml2ZS4KCkknbSBzY2VwdGljYWwsIHRob3VnaCwgYXMgaXQgaGFzICJzdXJwcmlz ZSIgaW4gdGhlIG5hbWUgc28gSSdtIGd1ZXNzaW5nCnRoZSBmaXJtd2FyZSBkb2Vzbid0IGtub3cg YWJvdXQgaXQsIHRoZSBkcml2ZSBwaHlzaWNhbGx5IGRpc2FwcGVhcnMgYW5kCnRoZSBGVyBzdGFy dHMgc3Bld2luZyBQQ0llIGVycm9ycy4uLgoKPiBJJ20gbm90IHN1cmUgaWYgdGhpcyBpcyB0aGUg ZXhhbXBsZSB5b3UncmUgbG9va2luZyBmb3IsIGJ1dAo+IHRha2UgYW4gcjc0MHhkIHNlcnZlciwg YW5kIHNsb3dseSB1bnBsdWcgYW4gSW50ZWwgTlZNRSBkcml2ZXMgYXQgYW4KPiBhbmdsZS4gWW91 J3JlIGxpa2VseSB0byBjcmFzaCB0aGUgbWFjaGluZS4KCk5vIG5vLCB0aGF0J3MgYWN0dWFsbHkg YSBncmVhdCBleGFtcGxlIQoKVGh4Lgo=