From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9CWg-0003aJ-1r for qemu-devel@nongnu.org; Thu, 19 Apr 2018 12:35:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9CWb-0003H6-69 for qemu-devel@nongnu.org; Thu, 19 Apr 2018 12:35:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59214 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9CWa-0003GM-VL for qemu-devel@nongnu.org; Thu, 19 Apr 2018 12:35:09 -0400 Date: Thu, 19 Apr 2018 19:34:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20180419190000-mutt-send-email-mst@kernel.org> References: <20180412151232.17506-1-tiwei.bie@intel.com> <20180412151232.17506-7-tiwei.bie@intel.com> <20180418192154-mutt-send-email-mst@kernel.org> <20180419111439.i6gfhnept6wy7uzp@debian> <20180419182035-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v3 6/6] vhost-user: support registering external host notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Liang, Cunming" , "Bie, Tiwei" , "jasowang@redhat.com" , "alex.williamson@redhat.com" , "stefanha@redhat.com" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "Daly, Dan" , "Tan, Jianfeng" , "Wang, Zhihong" , "Wang, Xiao W" On Thu, Apr 19, 2018 at 05:52:23PM +0200, Paolo Bonzini wrote: > On 19/04/2018 17:42, Michael S. Tsirkin wrote: > >> A compiler barrier is enough on strongly-ordered memory platform. > >> As it doesn't re-order store, PCI device won't see a stale index > >> value. But a weakly-ordered memory needs sfence. > > > > Oh you are right. > > > > So it's only needed for non-intel platforms or when packets are in > > WC memory then. And I don't know whether dpdk ever puts packets in WC > > memory. > > > > I guess we'll cross this bridge when we get to it. > > Non-TSO architectures seem important... > > Paolo Only if there are virtio offload engines on platforms with these architectures :) Worth working on for sure but doesn't have to block this patchset. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-3886-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 09AC458191A2 for ; Thu, 19 Apr 2018 09:35:15 -0700 (PDT) Date: Thu, 19 Apr 2018 19:34:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20180419190000-mutt-send-email-mst@kernel.org> References: <20180412151232.17506-1-tiwei.bie@intel.com> <20180412151232.17506-7-tiwei.bie@intel.com> <20180418192154-mutt-send-email-mst@kernel.org> <20180419111439.i6gfhnept6wy7uzp@debian> <20180419182035-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [virtio-dev] Re: [PATCH v3 6/6] vhost-user: support registering external host notifiers To: Paolo Bonzini Cc: "Liang, Cunming" , "Bie, Tiwei" , "jasowang@redhat.com" , "alex.williamson@redhat.com" , "stefanha@redhat.com" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "Daly, Dan" , "Tan, Jianfeng" , "Wang, Zhihong" , "Wang, Xiao W" List-ID: On Thu, Apr 19, 2018 at 05:52:23PM +0200, Paolo Bonzini wrote: > On 19/04/2018 17:42, Michael S. Tsirkin wrote: > >> A compiler barrier is enough on strongly-ordered memory platform. > >> As it doesn't re-order store, PCI device won't see a stale index > >> value. But a weakly-ordered memory needs sfence. > > > > Oh you are right. > > > > So it's only needed for non-intel platforms or when packets are in > > WC memory then. And I don't know whether dpdk ever puts packets in WC > > memory. > > > > I guess we'll cross this bridge when we get to it. > > Non-TSO architectures seem important... > > Paolo Only if there are virtio offload engines on platforms with these architectures :) Worth working on for sure but doesn't have to block this patchset. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org