From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [RFC PATCH v2 3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal. Date: Thu, 19 Apr 2018 21:03:23 +0200 Message-ID: <20180419190323.GF5635@pd.tnic> References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180416215903.7318-4-mr.nuke.me@gmail.com> <20180418175415.GJ4795@pd.tnic> <20180419154006.GE3600@pd.tnic> <977608e6-9f5d-c523-a78a-993ac5bfd55f@gmail.com> <20180419164528.GD5635@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Alex G." Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-Id: linux-acpi@vger.kernel.org (snip useful explanation). On Thu, Apr 19, 2018 at 12:40:54PM -0500, Alex G. wrote: > On the r740xd, FW just hides those errors from the OS with no further > notification. On this machine BIOS sets things up such that non-posted > requests report fatal (PCIe) errors. FW still tries very hard to hide > this from the OS, and I think the heuristic is that if the drive > physical presence is gone, don't even report the error. Ok, second question: can you detect from the error signatures alone that it was a surprise removal? How does such an error look like, in detail? Got error logs somewhere to dump? Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v2,3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal. From: Borislav Petkov Message-Id: <20180419190323.GF5635@pd.tnic> Date: Thu, 19 Apr 2018 21:03:23 +0200 To: "Alex G." Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-ID: KHNuaXAgdXNlZnVsIGV4cGxhbmF0aW9uKS4KCk9uIFRodSwgQXByIDE5LCAyMDE4IGF0IDEyOjQw OjU0UE0gLTA1MDAsIEFsZXggRy4gd3JvdGU6Cj4gT24gdGhlIHI3NDB4ZCwgRlcganVzdCBoaWRl cyB0aG9zZSBlcnJvcnMgZnJvbSB0aGUgT1Mgd2l0aCBubyBmdXJ0aGVyCj4gbm90aWZpY2F0aW9u LiBPbiB0aGlzIG1hY2hpbmUgQklPUyBzZXRzIHRoaW5ncyB1cCBzdWNoIHRoYXQgbm9uLXBvc3Rl ZAo+IHJlcXVlc3RzIHJlcG9ydCBmYXRhbCAoUENJZSkgZXJyb3JzLiBGVyBzdGlsbCB0cmllcyB2 ZXJ5IGhhcmQgdG8gaGlkZQo+IHRoaXMgZnJvbSB0aGUgT1MsIGFuZCBJIHRoaW5rIHRoZSBoZXVy aXN0aWMgaXMgdGhhdCBpZiB0aGUgZHJpdmUKPiBwaHlzaWNhbCBwcmVzZW5jZSBpcyBnb25lLCBk b24ndCBldmVuIHJlcG9ydCB0aGUgZXJyb3IuCgpPaywgc2Vjb25kIHF1ZXN0aW9uOiBjYW4geW91 IGRldGVjdCBmcm9tIHRoZSBlcnJvciBzaWduYXR1cmVzIGFsb25lIHRoYXQKaXQgd2FzIGEgc3Vy cHJpc2UgcmVtb3ZhbD8gSG93IGRvZXMgc3VjaCBhbiBlcnJvciBsb29rIGxpa2UsIGluIGRldGFp bD8KR290IGVycm9yIGxvZ3Mgc29tZXdoZXJlIHRvIGR1bXA/CgpUaHguCg==