From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH] net/mvpp2: fix build
Date: Fri, 20 Apr 2018 07:26:10 +0200
Message-ID: <20180420052610.GA30666@sh>
References: <20180419160934.24577-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, nsamsono@marvell.com, ferruh.yigit@intel.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com
 [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 2395E8BA7
 for <dev@dpdk.org>; Fri, 20 Apr 2018 07:26:13 +0200 (CEST)
Received: by mail-lf0-f65.google.com with SMTP id p142-v6so3353940lfd.6
 for <dev@dpdk.org>; Thu, 19 Apr 2018 22:26:13 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180419160934.24577-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Apr 19, 2018 at 06:09:34PM +0200, Thomas Monjalon wrote:
> The iterator RTE_ETH_FOREACH_DEV (added in below commit)
> requires to enable experimental APIs.
>
> Fixing also the config option rename in the build test.
>
> Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> Fixes: fe93968722af ("net/mrvl: rename PMD as mvpp2")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/test-build.sh     | 2 +-
>  drivers/net/mvpp2/Makefile | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 3362edcc5..28e032417 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -202,7 +202,7 @@ config () # <directory> <target> <options>
>  		test -z "$LIBMUSDK_PATH" || \
>  		sed -ri    's,(PMD_MRVL_CRYPTO=3D)n,\1y,' $1/.config
>  		test -z "$LIBMUSDK_PATH" || \
> -		sed -ri           's,(MRVL_PMD=3D)n,\1y,' $1/.config
> +		sed -ri          's,(MVPP2_PMD=3D)n,\1y,' $1/.config
>  		build_config_hook $1 $2 $3
>
>  		# Explicit enabler/disabler (uppercase)
> diff --git a/drivers/net/mvpp2/Makefile b/drivers/net/mvpp2/Makefile
> index 2383ec18c..db4576f9c 100644
> --- a/drivers/net/mvpp2/Makefile
> +++ b/drivers/net/mvpp2/Makefile
> @@ -27,6 +27,7 @@ CFLAGS +=3D -I$(LIBMUSDK_PATH)/include
>  CFLAGS +=3D -DMVCONF_TYPES_PUBLIC
>  CFLAGS +=3D -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
>  CFLAGS +=3D $(WERROR_FLAGS)
> +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API
>  CFLAGS +=3D -O3
>  LDLIBS +=3D -L$(LIBMUSDK_PATH)/lib
>  LDLIBS +=3D -lmusdk
> --
> 2.16.2
>

Looks good:
Acked-by: Tomasz Duszynski <tdu@semihalf.com>

--
- Tomasz Duszy=C5=84ski