From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 1/5] lib/ethdev: support for inline IPsec
 events
Date: Fri, 20 Apr 2018 08:14:31 -0700
Message-ID: <20180420081431.49c1907d@xeon-e3>
References: <1521630685-5179-1-git-send-email-anoob.joseph@caviumnetworks.com>
 <1523428846-9774-1-git-send-email-anoob.joseph@caviumnetworks.com>
 <1523428846-9774-2-git-send-email-anoob.joseph@caviumnetworks.com>
 <74e5016e-78ab-2515-0a50-b6f0520c6998@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal
 <akhil.goyal@nxp.com>, Declan Doherty <declan.doherty@intel.com>, Jingjing
 Wu <jingjing.wu@intel.com>, Radu Nicolau <radu.nicolau@intel.com>, Wenzhuo
 Lu <wenzhuo.lu@intel.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, Nelio
 Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org
To: Anoob Joseph <Anoob.Joseph@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f45.google.com (mail-pl0-f45.google.com
 [209.85.160.45]) by dpdk.org (Postfix) with ESMTP id 46255CF66
 for <dev@dpdk.org>; Fri, 20 Apr 2018 17:14:35 +0200 (CEST)
Received: by mail-pl0-f45.google.com with SMTP id e7-v6so5439425plt.6
 for <dev@dpdk.org>; Fri, 20 Apr 2018 08:14:35 -0700 (PDT)
In-Reply-To: <74e5016e-78ab-2515-0a50-b6f0520c6998@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 19 Apr 2018 14:45:01 +0530
Anoob Joseph <Anoob.Joseph@caviumnetworks.com> wrote:

> > +/**
> >    * The eth device event type for interrupt, and maybe others in the future.
> >    */
> >   enum rte_eth_event_type {
> > @@ -2446,6 +2486,7 @@ enum rte_eth_event_type {
> >   	RTE_ETH_EVENT_INTR_RESET,
> >   			/**< reset interrupt event, sent to VF on PF reset */
> >   	RTE_ETH_EVENT_VF_MBOX,  /**< message from the VF received by PF */
> > +	RTE_ETH_EVENT_IPSEC,    /**< IPsec offload related event */
> >   	RTE_ETH_EVENT_MACSEC,   /**< MACsec offload related event */
> >   	RTE_ETH_EVENT_INTR_RMV, /**< device removal event */
> >   	RTE_ETH_EVENT_NEW,      /**< port is probed */  


Putting new value in middle of enum risks breaking ABI compatiablity