All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S90 4/8] i40evf: Fix turning TSO, GSO and GRO on after
Date: Fri, 20 Apr 2018 01:41:36 -0700	[thread overview]
Message-ID: <20180420084140.8081-4-alice.michael@intel.com> (raw)
In-Reply-To: <20180420084140.8081-1-alice.michael@intel.com>

From: Pawe? Jab?o?ski <pawel.jablonski@intel.com>

This patch fixes the problem where each MTU change turns TSO,
GSO and GRO on from off state.

Now when TSO, GSO or GRO is turned off, MTU change does not
turn them on.

Signed-off-by: Pawe? Jab?o?ski <pawel.jablonski@intel.com>
---
 drivers/net/ethernet/intel/i40evf/i40evf_main.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 28a8cc4..3f04a182 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -3357,6 +3357,24 @@ int i40evf_process_config(struct i40evf_adapter *adapter)
 	if (vfres->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN)
 		netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
 
+	/* Do not turn on offloads when they are requested to be turned off.
+	 * TSO needs minimum 576 bytes to work correctly.
+	 */
+	if (netdev->wanted_features) {
+		if (!(netdev->wanted_features & NETIF_F_TSO) ||
+		    netdev->mtu < 576)
+			netdev->features &= ~NETIF_F_TSO;
+		if (!(netdev->wanted_features & NETIF_F_TSO6) ||
+		    netdev->mtu < 576)
+			netdev->features &= ~NETIF_F_TSO6;
+		if (!(netdev->wanted_features & NETIF_F_TSO_ECN))
+			netdev->features &= ~NETIF_F_TSO_ECN;
+		if (!(netdev->wanted_features & NETIF_F_GRO))
+			netdev->features &= ~NETIF_F_GRO;
+		if (!(netdev->wanted_features & NETIF_F_GSO))
+			netdev->features &= ~NETIF_F_GSO;
+	}
+
 	adapter->vsi.id = adapter->vsi_res->vsi_id;
 
 	adapter->vsi.back = adapter;
-- 
2.9.5


  parent reply	other threads:[~2018-04-20  8:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20  8:41 [Intel-wired-lan] [next PATCH S90 1/8] i40e/i40evf: cleanup incorrect function doxygen comments Alice Michael
2018-04-20  8:41 ` [Intel-wired-lan] [next PATCH S90 2/8] i40e: fix reading LLDP configuration Alice Michael
2018-04-23 20:56   ` Bowers, AndrewX
2018-04-20  8:41 ` [Intel-wired-lan] [next PATCH S90 3/8] i40e: Add advertising 10G LR mode Alice Michael
2018-04-23 20:56   ` Bowers, AndrewX
2018-04-20  8:41 ` Alice Michael [this message]
2018-04-23  8:55   ` [Intel-wired-lan] [next PATCH S90 4/8] i40evf: Fix turning TSO, GSO and GRO on after Jablonski, Pawel
2018-04-23 20:57   ` Bowers, AndrewX
2018-04-20  8:41 ` [Intel-wired-lan] [next PATCH S90 5/8] i40e: Fix multiple issues with UDP tunnel offload filter configuration Alice Michael
2018-04-23 20:57   ` Bowers, AndrewX
2018-04-20  8:41 ` [Intel-wired-lan] [next PATCH S90 6/8] i40e: avoid overflow in i40e_ptp_adjfreq() Alice Michael
2018-04-23 20:58   ` Bowers, AndrewX
2018-04-20  8:41 ` [Intel-wired-lan] [next PATCH S90 7/8] i40e/i40evf: take into account queue map from vf when handling queues Alice Michael
2018-04-23 20:58   ` Bowers, AndrewX
2018-04-20  8:41 ` [Intel-wired-lan] [next PATCH S90 8/8] i40e: use %pI4b instead of byte swapping before dev_err Alice Michael
2018-04-23 20:59   ` Bowers, AndrewX
2018-04-23 20:55 ` [Intel-wired-lan] [next PATCH S90 1/8] i40e/i40evf: cleanup incorrect function doxygen comments Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180420084140.8081-4-alice.michael@intel.com \
    --to=alice.michael@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.