On Fri, Apr 20, 2018 at 01:34:14PM +0200, Greg Kurz wrote: > On Tue, 17 Apr 2018 17:17:15 +1000 > David Gibson wrote: > > > In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized > > based on on ppc64_radix_guest(). Which seems reasonable, except that > > ppc64_radix_guest() is based on spapr->patb_entry which is only set up > > in spapr_machine_reset, called much later than cpu_ppc_set_papr(). > > > > So the initialization here is pointless. The base cpu initialization > > already sets a value that's good enough until the guest uses an hcall to > > configure it's preferred MMU mode. > > > > Signed-off-by: David Gibson > > --- > > Reviewed-by: Greg Kurz Merged to ppc-for-2.13. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson