From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Daniel Mack <daniel@zonque.org>
Cc: linux-media@vger.kernel.org, slongerbeam@gmail.com, mchehab@kernel.org
Subject: Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls
Date: Fri, 20 Apr 2018 21:00:35 +0200 [thread overview]
Message-ID: <20180420190035.bahliwck7rplqvtc@flea> (raw)
In-Reply-To: <5d51bdb7-936a-3a6c-bc6d-168cd5221e4d@zonque.org>
On Fri, Apr 20, 2018 at 04:29:42PM +0200, Daniel Mack wrote:
> Hi,
>
> On Friday, April 20, 2018 04:15 PM, Maxime Ripard wrote:
> > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote:
>
> >> struct ov5640_ctrls {
> >> struct v4l2_ctrl_handler handler;
> >> + struct {
> >> + struct v4l2_ctrl *link_freq;
> >> + struct v4l2_ctrl *pixel_rate;
> >> + };
> >> struct {
> >> struct v4l2_ctrl *auto_exp;
> >> struct v4l2_ctrl *exposure;
> >> @@ -732,6 +752,8 @@ static const struct ov5640_mode_info ov5640_mode_init_data = {
> >> .dn_mode = SUBSAMPLING,
> >> .width = 640,
> >> .height = 480,
> >> + .pixel_rate = 27766666,
> >> + .link_freq_idx = OV5640_LINK_FREQ_111,
> >
> > I'm not sure where this is coming from, but on a parallel sensor I
> > have a quite different pixel rate.
>
> Ah, interesting. What exactly do you mean by 'parallel'? What kind of
> module is that, and what are your pixel rates?
An RGB bus, or MIPI-DPI, or basically a pixel clock + 1 line for each
bit. The sensor can operate using both that bus and a MIPI-CSI2 one.
You have the list of pixel rates in the patch I've linked before:
https://patchwork.linuxtv.org/patch/48710/
There's one pixel sent per clock cycle, so the pixel rate is the same
than the clock rate.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-20 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 9:44 [PATCH 1/3] media: ov5640: initialize mode data structs by name Daniel Mack
2018-04-20 9:44 ` [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls Daniel Mack
2018-04-20 14:15 ` Maxime Ripard
2018-04-20 14:29 ` Daniel Mack
2018-04-20 19:00 ` Maxime Ripard [this message]
2018-04-24 10:22 ` Sakari Ailus
2018-04-24 12:03 ` Daniel Mack
2018-04-26 8:31 ` Sakari Ailus
2018-04-20 9:44 ` [PATCH 3/3] media: ov5640: add support for xclk frequency control Daniel Mack
2018-04-20 14:07 ` Maxime Ripard
2018-04-24 10:24 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420190035.bahliwck7rplqvtc@flea \
--to=maxime.ripard@bootlin.com \
--cc=daniel@zonque.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.