From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752578AbeDTWNs (ORCPT ); Fri, 20 Apr 2018 18:13:48 -0400 Received: from mga14.intel.com ([192.55.52.115]:15348 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbeDTWNq (ORCPT ); Fri, 20 Apr 2018 18:13:46 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,303,1520924400"; d="scan'208";a="49572128" Date: Fri, 20 Apr 2018 15:13:46 -0700 From: Rodrigo Vivi To: Jani Nikula Cc: Souptick Joarder , Matthew Wilcox , airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] gpu: drm: i915: Change return type to vm_fault_t Message-ID: <20180420221346.GN1310@intel.com> References: <20180417151127.GA31655@jordon-HP-15-Notebook-PC> <87h8o9g8be.fsf@intel.com> <20180417161557.GA3603@bombadil.infradead.org> <871sfdxe0r.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871sfdxe0r.fsf@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 18, 2018 at 08:46:44AM +0300, Jani Nikula wrote: > On Tue, 17 Apr 2018, Souptick Joarder wrote: > > On 17-Apr-2018 9:45 PM, "Matthew Wilcox" wrote: > >> > >> On Tue, Apr 17, 2018 at 09:14:32PM +0530, Souptick Joarder wrote: > >> > Not exactly. The plan for these patches is to introduce new vm_fault_t > > type > >> > in vm_operations_struct fault handlers. It's now available in 4.17-rc1. > > We will > >> > push all the required drivers/filesystem changes through different > > maintainers > >> > to linus tree. Once everything is converted into vm_fault_t type then > > Changing > >> > it from a signed to an unsigned int causes GCC to warn about an > > assignment > >> > from an incompatible type -- int foo(void) is incompatible with > >> > unsigned int foo(void). > >> > > >> > Please refer 1c8f422059ae ("mm: change return type to vm_fault_t") in > > 4.17-rc1. > >> > >> I think this patch would be clearer if you did > >> > >> - int ret; > >> + int err; > >> + vm_fault_t ret; > >> > >> Then it would be clearer to the maintainer that you're splitting apart the > >> VM_FAULT and errno codes. > >> > >> Sorry for not catching this during initial review. > > > > Ok, I will make required changes and send v2. Sorry, even I missed this :) > > I'm afraid Daniel is closer to the truth. +1. > My bad, sorry for the noise. I opened this thread to add exactly question/noise ;). So my recommendation for some next time is to make the intention clear on the commit message itself from the begin. > > BR, > Jani. > > > > >> > >> > On Tue, Apr 17, 2018 at 8:59 PM, Jani Nikula > >> > wrote: > >> > > On Tue, 17 Apr 2018, Souptick Joarder wrote: > >> > >> Use new return type vm_fault_t for fault handler. For > >> > >> now, this is just documenting that the function returns > >> > >> a VM_FAULT value rather than an errno. Once all instances > >> > >> are converted, vm_fault_t will become a distinct type. > >> > >> > >> > >> Reference id -> 1c8f422059ae ("mm: change return type to > >> > >> vm_fault_t") > >> > >> > >> > >> Signed-off-by: Souptick Joarder > >> > >> --- > >> > >> drivers/gpu/drm/i915/i915_drv.h | 3 ++- > >> > >> drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++------- > >> > >> 2 files changed, 10 insertions(+), 8 deletions(-) > >> > >> > >> > >> diff --git a/drivers/gpu/drm/i915/i915_drv.h > > b/drivers/gpu/drm/i915/i915_drv.h > >> > >> index a42deeb..95b0d50 100644 > >> > >> --- a/drivers/gpu/drm/i915/i915_drv.h > >> > >> +++ b/drivers/gpu/drm/i915/i915_drv.h > >> > >> @@ -51,6 +51,7 @@ > >> > >> #include > >> > >> #include > >> > >> #include > >> > >> +#include > >> > >> > >> > >> #include "i915_params.h" > >> > >> #include "i915_reg.h" > >> > >> @@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct > > drm_i915_private *dev_priv, > >> > >> unsigned int flags); > >> > >> int __must_check i915_gem_suspend(struct drm_i915_private > > *dev_priv); > >> > >> void i915_gem_resume(struct drm_i915_private *dev_priv); > >> > >> -int i915_gem_fault(struct vm_fault *vmf); > >> > >> +vm_fault_t i915_gem_fault(struct vm_fault *vmf); > >> > >> int i915_gem_object_wait(struct drm_i915_gem_object *obj, > >> > >> unsigned int flags, > >> > >> long timeout, > >> > >> diff --git a/drivers/gpu/drm/i915/i915_gem.c > > b/drivers/gpu/drm/i915/i915_gem.c > >> > >> index dd89abd..bdac690 100644 > >> > >> --- a/drivers/gpu/drm/i915/i915_gem.c > >> > >> +++ b/drivers/gpu/drm/i915/i915_gem.c > >> > >> @@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void) > >> > >> * The current feature set supported by i915_gem_fault() and thus > > GTT mmaps > >> > >> * is exposed via I915_PARAM_MMAP_GTT_VERSION (see > > i915_gem_mmap_gtt_version). > >> > >> */ > >> > >> -int i915_gem_fault(struct vm_fault *vmf) > >> > >> +vm_fault_t i915_gem_fault(struct vm_fault *vmf) > >> > >> { > >> > >> #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */ > >> > >> struct vm_area_struct *area = vmf->vma; > >> > >> @@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf) > >> > >> pgoff_t page_offset; > >> > >> unsigned int flags; > >> > >> int ret; > >> > >> + vm_fault_t retval; > >> > > > >> > > What's the point of changing the name? An unnecessary change. > >> > > > >> > > BR, > >> > > Jani. > >> > > > >> > >> > >> > >> /* We don't use vmf->pgoff since that has the fake offset */ > >> > >> page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT; > >> > >> @@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf) > >> > >> * and so needs to be reported. > >> > >> */ > >> > >> if (!i915_terminally_wedged(&dev_priv->gpu_error)) { > >> > >> - ret = VM_FAULT_SIGBUS; > >> > >> + retval = VM_FAULT_SIGBUS; > >> > >> break; > >> > >> } > >> > >> case -EAGAIN: > >> > >> @@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf) > >> > >> * EBUSY is ok: this just means that another thread > >> > >> * already did the job. > >> > >> */ > >> > >> - ret = VM_FAULT_NOPAGE; > >> > >> + retval = VM_FAULT_NOPAGE; > >> > >> break; > >> > >> case -ENOMEM: > >> > >> - ret = VM_FAULT_OOM; > >> > >> + retval = VM_FAULT_OOM; > >> > >> break; > >> > >> case -ENOSPC: > >> > >> case -EFAULT: > >> > >> - ret = VM_FAULT_SIGBUS; > >> > >> + retval = VM_FAULT_SIGBUS; > >> > >> break; > >> > >> default: > >> > >> WARN_ONCE(ret, "unhandled error in i915_gem_fault: > > %i\n", ret); > >> > >> - ret = VM_FAULT_SIGBUS; > >> > >> + retval = VM_FAULT_SIGBUS; > >> > >> break; > >> > >> } > >> > >> - return ret; > >> > >> + return retval; > >> > >> } > >> > >> > >> > >> static void __i915_gem_object_release_mmap(struct > > drm_i915_gem_object *obj) > >> > >> -- > >> > >> 1.9.1 > >> > >> > >> > > > >> > > -- > >> > > Jani Nikula, Intel Open Source Technology Center > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [Intel-gfx] [PATCH] gpu: drm: i915: Change return type to vm_fault_t Date: Fri, 20 Apr 2018 15:13:46 -0700 Message-ID: <20180420221346.GN1310@intel.com> References: <20180417151127.GA31655@jordon-HP-15-Notebook-PC> <87h8o9g8be.fsf@intel.com> <20180417161557.GA3603@bombadil.infradead.org> <871sfdxe0r.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <871sfdxe0r.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: Matthew Wilcox , airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Souptick Joarder List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMTgsIDIwMTggYXQgMDg6NDY6NDRBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAxNyBBcHIgMjAxOCwgU291cHRpY2sgSm9hcmRlciA8anJkci5saW51eEBn bWFpbC5jb20+IHdyb3RlOgo+ID4gT24gMTctQXByLTIwMTggOTo0NSBQTSwgIk1hdHRoZXcgV2ls Y294IiA8d2lsbHlAaW5mcmFkZWFkLm9yZz4gd3JvdGU6Cj4gPj4KPiA+PiBPbiBUdWUsIEFwciAx NywgMjAxOCBhdCAwOToxNDozMlBNICswNTMwLCBTb3VwdGljayBKb2FyZGVyIHdyb3RlOgo+ID4+ ID4gTm90IGV4YWN0bHkuIFRoZSBwbGFuIGZvciB0aGVzZSBwYXRjaGVzIGlzIHRvIGludHJvZHVj ZSBuZXcgdm1fZmF1bHRfdAo+ID4gdHlwZQo+ID4+ID4gaW4gdm1fb3BlcmF0aW9uc19zdHJ1Y3Qg ZmF1bHQgaGFuZGxlcnMuIEl0J3Mgbm93IGF2YWlsYWJsZSBpbiA0LjE3LXJjMS4KPiA+IFdlIHdp bGwKPiA+PiA+IHB1c2ggYWxsIHRoZSByZXF1aXJlZCBkcml2ZXJzL2ZpbGVzeXN0ZW0gY2hhbmdl cyB0aHJvdWdoIGRpZmZlcmVudAo+ID4gbWFpbnRhaW5lcnMKPiA+PiA+IHRvIGxpbnVzIHRyZWUu IE9uY2UgZXZlcnl0aGluZyBpcyBjb252ZXJ0ZWQgaW50byB2bV9mYXVsdF90IHR5cGUgdGhlbgo+ ID4gQ2hhbmdpbmcKPiA+PiA+IGl0IGZyb20gYSBzaWduZWQgdG8gYW4gdW5zaWduZWQgaW50IGNh dXNlcyBHQ0MgdG8gd2FybiBhYm91dCBhbgo+ID4gYXNzaWdubWVudAo+ID4+ID4gZnJvbSBhbiBp bmNvbXBhdGlibGUgdHlwZSAtLSBpbnQgZm9vKHZvaWQpIGlzIGluY29tcGF0aWJsZSB3aXRoCj4g Pj4gPiB1bnNpZ25lZCBpbnQgZm9vKHZvaWQpLgo+ID4+ID4KPiA+PiA+IFBsZWFzZSByZWZlciAx YzhmNDIyMDU5YWUgKCJtbTogY2hhbmdlIHJldHVybiB0eXBlIHRvIHZtX2ZhdWx0X3QiKSBpbgo+ ID4gNC4xNy1yYzEuCj4gPj4KPiA+PiBJIHRoaW5rIHRoaXMgcGF0Y2ggd291bGQgYmUgY2xlYXJl ciBpZiB5b3UgZGlkCj4gPj4KPiA+PiAtICAgICAgIGludCByZXQ7Cj4gPj4gKyAgICAgICBpbnQg ZXJyOwo+ID4+ICsgICAgICAgdm1fZmF1bHRfdCByZXQ7Cj4gPj4KPiA+PiBUaGVuIGl0IHdvdWxk IGJlIGNsZWFyZXIgdG8gdGhlIG1haW50YWluZXIgdGhhdCB5b3UncmUgc3BsaXR0aW5nIGFwYXJ0 IHRoZQo+ID4+IFZNX0ZBVUxUIGFuZCBlcnJubyBjb2Rlcy4KPiA+Pgo+ID4+IFNvcnJ5IGZvciBu b3QgY2F0Y2hpbmcgdGhpcyBkdXJpbmcgaW5pdGlhbCByZXZpZXcuCj4gPgo+ID4gT2ssIEkgd2ls bCBtYWtlIHJlcXVpcmVkIGNoYW5nZXMgYW5kIHNlbmQgdjIuIFNvcnJ5LCBldmVuIEkgbWlzc2Vk IHRoaXMgOikKPiAKPiBJJ20gYWZyYWlkIERhbmllbCBpcyBjbG9zZXIgdG8gdGhlIHRydXRoLgoK KzEuCgo+IE15IGJhZCwgc29ycnkgZm9yIHRoZSBub2lzZS4KCkkgb3BlbmVkIHRoaXMgdGhyZWFk IHRvIGFkZCBleGFjdGx5IHF1ZXN0aW9uL25vaXNlIDspLgoKU28gbXkgcmVjb21tZW5kYXRpb24g Zm9yIHNvbWUgbmV4dCB0aW1lIGlzIHRvIG1ha2UgdGhlIGludGVudGlvbiBjbGVhcgpvbiB0aGUg Y29tbWl0IG1lc3NhZ2UgaXRzZWxmIGZyb20gdGhlIGJlZ2luLgoKPiAKPiBCUiwKPiBKYW5pLgo+ IAo+IAo+IAo+ID4+Cj4gPj4gPiBPbiBUdWUsIEFwciAxNywgMjAxOCBhdCA4OjU5IFBNLCBKYW5p IE5pa3VsYQo+ID4+ID4gPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPj4g PiA+IE9uIFR1ZSwgMTcgQXByIDIwMTgsIFNvdXB0aWNrIEpvYXJkZXIgPGpyZHIubGludXhAZ21h aWwuY29tPiB3cm90ZToKPiA+PiA+ID4+IFVzZSBuZXcgcmV0dXJuIHR5cGUgdm1fZmF1bHRfdCBm b3IgZmF1bHQgaGFuZGxlci4gRm9yCj4gPj4gPiA+PiBub3csIHRoaXMgaXMganVzdCBkb2N1bWVu dGluZyB0aGF0IHRoZSBmdW5jdGlvbiByZXR1cm5zCj4gPj4gPiA+PiBhIFZNX0ZBVUxUIHZhbHVl IHJhdGhlciB0aGFuIGFuIGVycm5vLiBPbmNlIGFsbCBpbnN0YW5jZXMKPiA+PiA+ID4+IGFyZSBj b252ZXJ0ZWQsIHZtX2ZhdWx0X3Qgd2lsbCBiZWNvbWUgYSBkaXN0aW5jdCB0eXBlLgo+ID4+ID4g Pj4KPiA+PiA+ID4+IFJlZmVyZW5jZSBpZCAtPiAxYzhmNDIyMDU5YWUgKCJtbTogY2hhbmdlIHJl dHVybiB0eXBlIHRvCj4gPj4gPiA+PiB2bV9mYXVsdF90IikKPiA+PiA+ID4+Cj4gPj4gPiA+PiBT aWduZWQtb2ZmLWJ5OiBTb3VwdGljayBKb2FyZGVyIDxqcmRyLmxpbnV4QGdtYWlsLmNvbT4KPiA+ PiA+ID4+IC0tLQo+ID4+ID4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAg MyArKy0KPiA+PiA+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgMTUgKysr KysrKystLS0tLS0tCj4gPj4gPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCsp LCA4IGRlbGV0aW9ucygtKQo+ID4+ID4gPj4KPiA+PiA+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmgKPiA+PiA+ID4+IGluZGV4IGE0MmRlZWIuLjk1YjBkNTAgMTAwNjQ0Cj4gPj4gPiA+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPj4gPiA+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPj4gPiA+PiBAQCAtNTEsNiArNTEsNyBAQAo+ ID4+ID4gPj4gICNpbmNsdWRlIDxkcm0vZHJtX2dlbS5oPgo+ID4+ID4gPj4gICNpbmNsdWRlIDxk cm0vZHJtX2F1dGguaD4KPiA+PiA+ID4+ICAjaW5jbHVkZSA8ZHJtL2RybV9jYWNoZS5oPgo+ID4+ ID4gPj4gKyNpbmNsdWRlIDxsaW51eC9tbV90eXBlcy5oPgo+ID4+ID4gPj4KPiA+PiA+ID4+ICAj aW5jbHVkZSAiaTkxNV9wYXJhbXMuaCIKPiA+PiA+ID4+ICAjaW5jbHVkZSAiaTkxNV9yZWcuaCIK PiA+PiA+ID4+IEBAIC0zMzYzLDcgKzMzNjQsNyBAQCBpbnQgaTkxNV9nZW1fd2FpdF9mb3JfaWRs ZShzdHJ1Y3QKPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4+ID4gPj4gICAgICAg ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFncyk7Cj4gPj4gPiA+PiAgaW50IF9f bXVzdF9jaGVjayBpOTE1X2dlbV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gPiAq ZGV2X3ByaXYpOwo+ID4+ID4gPj4gIHZvaWQgaTkxNV9nZW1fcmVzdW1lKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdik7Cj4gPj4gPiA+PiAtaW50IGk5MTVfZ2VtX2ZhdWx0KHN0cnVj dCB2bV9mYXVsdCAqdm1mKTsKPiA+PiA+ID4+ICt2bV9mYXVsdF90IGk5MTVfZ2VtX2ZhdWx0KHN0 cnVjdCB2bV9mYXVsdCAqdm1mKTsKPiA+PiA+ID4+ICBpbnQgaTkxNV9nZW1fb2JqZWN0X3dhaXQo c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiA+PiA+ID4+ICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW50IGZsYWdzLAo+ID4+ID4gPj4gICAgICAgICAgICAgICAgICAg ICAgICBsb25nIHRpbWVvdXQsCj4gPj4gPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g Pj4gPiA+PiBpbmRleCBkZDg5YWJkLi5iZGFjNjkwIDEwMDY0NAo+ID4+ID4gPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4+ID4gPj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4+ID4gPj4gQEAgLTE4ODIsNyArMTg4Miw3IEBAIGludCBp OTE1X2dlbV9tbWFwX2d0dF92ZXJzaW9uKHZvaWQpCj4gPj4gPiA+PiAgICogVGhlIGN1cnJlbnQg ZmVhdHVyZSBzZXQgc3VwcG9ydGVkIGJ5IGk5MTVfZ2VtX2ZhdWx0KCkgYW5kIHRodXMKPiA+IEdU VCBtbWFwcwo+ID4+ID4gPj4gICAqIGlzIGV4cG9zZWQgdmlhIEk5MTVfUEFSQU1fTU1BUF9HVFRf VkVSU0lPTiAoc2VlCj4gPiBpOTE1X2dlbV9tbWFwX2d0dF92ZXJzaW9uKS4KPiA+PiA+ID4+ICAg Ki8KPiA+PiA+ID4+IC1pbnQgaTkxNV9nZW1fZmF1bHQoc3RydWN0IHZtX2ZhdWx0ICp2bWYpCj4g Pj4gPiA+PiArdm1fZmF1bHRfdCBpOTE1X2dlbV9mYXVsdChzdHJ1Y3Qgdm1fZmF1bHQgKnZtZikK PiA+PiA+ID4+ICB7Cj4gPj4gPiA+PiAgI2RlZmluZSBNSU5fQ0hVTktfUEFHRVMgKCgxIDw8IDIw KSA+PiBQQUdFX1NISUZUKSAvKiAxIE1pQiAqLwo+ID4+ID4gPj4gICAgICAgc3RydWN0IHZtX2Fy ZWFfc3RydWN0ICphcmVhID0gdm1mLT52bWE7Cj4gPj4gPiA+PiBAQCAtMTg5NSw2ICsxODk1LDcg QEAgaW50IGk5MTVfZ2VtX2ZhdWx0KHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+ID4+ID4gPj4gICAg ICAgcGdvZmZfdCBwYWdlX29mZnNldDsKPiA+PiA+ID4+ICAgICAgIHVuc2lnbmVkIGludCBmbGFn czsKPiA+PiA+ID4+ICAgICAgIGludCByZXQ7Cj4gPj4gPiA+PiArICAgICB2bV9mYXVsdF90IHJl dHZhbDsKPiA+PiA+ID4KPiA+PiA+ID4gV2hhdCdzIHRoZSBwb2ludCBvZiBjaGFuZ2luZyB0aGUg bmFtZT8gQW4gdW5uZWNlc3NhcnkgY2hhbmdlLgo+ID4+ID4gPgo+ID4+ID4gPiBCUiwKPiA+PiA+ ID4gSmFuaS4KPiA+PiA+ID4KPiA+PiA+ID4+Cj4gPj4gPiA+PiAgICAgICAvKiBXZSBkb24ndCB1 c2Ugdm1mLT5wZ29mZiBzaW5jZSB0aGF0IGhhcyB0aGUgZmFrZSBvZmZzZXQgKi8KPiA+PiA+ID4+ ICAgICAgIHBhZ2Vfb2Zmc2V0ID0gKHZtZi0+YWRkcmVzcyAtIGFyZWEtPnZtX3N0YXJ0KSA+PiBQ QUdFX1NISUZUOwo+ID4+ID4gPj4gQEAgLTIwMDAsNyArMjAwMSw3IEBAIGludCBpOTE1X2dlbV9m YXVsdChzdHJ1Y3Qgdm1fZmF1bHQgKnZtZikKPiA+PiA+ID4+ICAgICAgICAgICAgICAgICogYW5k IHNvIG5lZWRzIHRvIGJlIHJlcG9ydGVkLgo+ID4+ID4gPj4gICAgICAgICAgICAgICAgKi8KPiA+ PiA+ID4+ICAgICAgICAgICAgICAgaWYgKCFpOTE1X3Rlcm1pbmFsbHlfd2VkZ2VkKCZkZXZfcHJp di0+Z3B1X2Vycm9yKSkgewo+ID4+ID4gPj4gLSAgICAgICAgICAgICAgICAgICAgIHJldCA9IFZN X0ZBVUxUX1NJR0JVUzsKPiA+PiA+ID4+ICsgICAgICAgICAgICAgICAgICAgICByZXR2YWwgPSBW TV9GQVVMVF9TSUdCVVM7Cj4gPj4gPiA+PiAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4g Pj4gPiA+PiAgICAgICAgICAgICAgIH0KPiA+PiA+ID4+ICAgICAgIGNhc2UgLUVBR0FJTjoKPiA+ PiA+ID4+IEBAIC0yMDE3LDIxICsyMDE4LDIxIEBAIGludCBpOTE1X2dlbV9mYXVsdChzdHJ1Y3Qg dm1fZmF1bHQgKnZtZikKPiA+PiA+ID4+ICAgICAgICAgICAgICAgICogRUJVU1kgaXMgb2s6IHRo aXMganVzdCBtZWFucyB0aGF0IGFub3RoZXIgdGhyZWFkCj4gPj4gPiA+PiAgICAgICAgICAgICAg ICAqIGFscmVhZHkgZGlkIHRoZSBqb2IuCj4gPj4gPiA+PiAgICAgICAgICAgICAgICAqLwo+ID4+ ID4gPj4gLSAgICAgICAgICAgICByZXQgPSBWTV9GQVVMVF9OT1BBR0U7Cj4gPj4gPiA+PiArICAg ICAgICAgICAgIHJldHZhbCA9IFZNX0ZBVUxUX05PUEFHRTsKPiA+PiA+ID4+ICAgICAgICAgICAg ICAgYnJlYWs7Cj4gPj4gPiA+PiAgICAgICBjYXNlIC1FTk9NRU06Cj4gPj4gPiA+PiAtICAgICAg ICAgICAgIHJldCA9IFZNX0ZBVUxUX09PTTsKPiA+PiA+ID4+ICsgICAgICAgICAgICAgcmV0dmFs ID0gVk1fRkFVTFRfT09NOwo+ID4+ID4gPj4gICAgICAgICAgICAgICBicmVhazsKPiA+PiA+ID4+ ICAgICAgIGNhc2UgLUVOT1NQQzoKPiA+PiA+ID4+ICAgICAgIGNhc2UgLUVGQVVMVDoKPiA+PiA+ ID4+IC0gICAgICAgICAgICAgcmV0ID0gVk1fRkFVTFRfU0lHQlVTOwo+ID4+ID4gPj4gKyAgICAg ICAgICAgICByZXR2YWwgPSBWTV9GQVVMVF9TSUdCVVM7Cj4gPj4gPiA+PiAgICAgICAgICAgICAg IGJyZWFrOwo+ID4+ID4gPj4gICAgICAgZGVmYXVsdDoKPiA+PiA+ID4+ICAgICAgICAgICAgICAg V0FSTl9PTkNFKHJldCwgInVuaGFuZGxlZCBlcnJvciBpbiBpOTE1X2dlbV9mYXVsdDoKPiA+ICVp XG4iLCByZXQpOwo+ID4+ID4gPj4gLSAgICAgICAgICAgICByZXQgPSBWTV9GQVVMVF9TSUdCVVM7 Cj4gPj4gPiA+PiArICAgICAgICAgICAgIHJldHZhbCA9IFZNX0ZBVUxUX1NJR0JVUzsKPiA+PiA+ ID4+ICAgICAgICAgICAgICAgYnJlYWs7Cj4gPj4gPiA+PiAgICAgICB9Cj4gPj4gPiA+PiAtICAg ICByZXR1cm4gcmV0Owo+ID4+ID4gPj4gKyAgICAgcmV0dXJuIHJldHZhbDsKPiA+PiA+ID4+ICB9 Cj4gPj4gPiA+Pgo+ID4+ID4gPj4gIHN0YXRpYyB2b2lkIF9faTkxNV9nZW1fb2JqZWN0X3JlbGVh c2VfbW1hcChzdHJ1Y3QKPiA+IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiA+PiA+ID4+IC0t Cj4gPj4gPiA+PiAxLjkuMQo+ID4+ID4gPj4KPiA+PiA+ID4KPiA+PiA+ID4gLS0KPiA+PiA+ID4g SmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCj4gCj4gLS0g Cj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=