From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [RFC v2 4/9] libxl_qmp: Move the buffer realloc to the same scope level as read Date: Mon, 23 Apr 2018 10:03:39 +0100 Message-ID: <20180423090339.g7ikb3h2ss25afmj@citrix.com> References: <20180416173227.22671-1-anthony.perard@citrix.com> <20180416173227.22671-5-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fAXNx-0004SN-LG for xen-devel@lists.xenproject.org; Mon, 23 Apr 2018 09:03:45 +0000 Content-Disposition: inline In-Reply-To: <20180416173227.22671-5-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBBcHIgMTYsIDIwMTggYXQgMDY6MzI6MjJQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gSW4gcW1wX25leHQoKSwgdGhlIGlubmVyIGxvb3Agc2hvdWxkIG9ubHkgdHJ5IHRv IHBhcnNlIG1lc3NhZ2VzIGZyb20KPiBRTVAsIGlmIHRoZXJlIGlzIG1vcmUgdGhhbiBvbmUuCj4g Cj4gVGhlIGhhbmRsaW5nIG9mIHRoZSByZWNlaXZlIGJ1ZmZlciAoJ2luY29tcGxldGUnKSwgc2hv dWxkIGJlIGRvbmUgYXQgdGhlCj4gc2FtZSBzY29wZSBsZXZlbCBhcyByZWFkKCkuIEl0IGRvZXNu J3QgbmVlZCB0byBiZSBoYW5kbGUgbW9yZSB0aGF0IG9uY2UKPiBhZnRlciBhIHJlYWQuCj4gCgpJ biBnZW5lcmFsIEkgYWdyZWUgdGhpcyBpcyBhIGJldHRlciBpZGVhIHRoYW4gdGhlIGN1cnJlbnQg Y29kZS4KCj4gQmVmb3JlIHRoaXMgcGF0Y2gsIHdoZW4gb24gbWVzc2FnZSB3aGF0IGhhbmRsZWQs IHRoZSBpbm5lciBsb29wIHdvdWxkCgpTb3JyeSwgSSBmYWlsZWQgdG8gcGFyc2UgIndoZW4gb24g bWVzc2FnZSB3aGF0IGhhbmRsZWQiLgoKPiByZXN0YXJ0IGJ5IGFkZGluZyB0aGUgJ2J1ZmZlcicg aW50byAnaW5jb21wbGV0ZScgKGFmdGVyIHJlYWxsb2NhdGlvbikuCj4gU2luY2UgJ3JkJyB3YXMg bm90IHJlc2V0LCB0aGUgYnVmZmVyIHdvdWxkIGJlIHN0cmNhdCBhIHNlY29uZCB0aW1lLgo+IEFm dGVyIHRoYXQsIHRoZSBzdHJlYW0gZnJvbSB0aGUgUU1QIHNlcnZlciB3b3VsZCBoYXZlIHN5bnRh eCBlcnJvciwgYW5kCj4gdGhlIHBhcnNvciB3b3VsZCB0aHJvdyBlcnJvcnMuCj4gCj4gVGhpcyBp cyB1bmxpa2VseSB0byBoYXBwZW4gYXMgdGhlIHJlY2VpdmUgYnVmZmVyIGlzIHZlcnkgbGFyZ2Uu IEFuZAo+IHJlY2VpdmluZyB0d28gbWVzc2FnZXMgaW4gYSByb3cgaXMgdW5saWtlbHkuIEluIHRo ZSBjdXJyZW50IGNhc2UsIHRoaXMKPiBjb3VsZCBiZSBhbiBldmVudCBhbmQgYSByZXNwb25zZSB0 byBhIGNvbW1hbmQuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnku cGVyYXJkQGNpdHJpeC5jb20+Cj4gLS0tCj4gIHRvb2xzL2xpYnhsL2xpYnhsX3FtcC5jIHwgMzEg KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTYgaW5z ZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhs L2xpYnhsX3FtcC5jIGIvdG9vbHMvbGlieGwvbGlieGxfcW1wLmMKPiBpbmRleCA0ZDIwN2MzODQy Li5hMjVmNDQ1ZmI2IDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX3FtcC5jCj4gKysr IGIvdG9vbHMvbGlieGwvbGlieGxfcW1wLmMKPiBAQCAtNTI0LDIzICs1MjQsMjQgQEAgc3RhdGlj IGludCBxbXBfbmV4dChsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9fcW1wX2hhbmRsZXIgKnFtcCkKPiAg Cj4gICAgICAgICAgREVCVUdfUkVQT1JUX1JFQ0VJVkVEKHFtcC0+ZG9taWQsIHFtcC0+YnVmZmVy LCAoaW50KXJkKTsKPiAgCj4gKyAgICAgICAgaWYgKGluY29tcGxldGUpIHsKPiArICAgICAgICAg ICAgc2l6ZV90IGN1cnJlbnRfcG9zID0gcyAtIGluY29tcGxldGU7Cj4gKyAgICAgICAgICAgIGlu Y29tcGxldGUgPSBsaWJ4bF9fcmVhbGxvYyhnYywgaW5jb21wbGV0ZSwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluY29tcGxldGVfc2l6ZSArIHJkICsgMSk7Cj4g KyAgICAgICAgICAgIHN0cm5jYXQoaW5jb21wbGV0ZSArIGluY29tcGxldGVfc2l6ZSwgcW1wLT5i dWZmZXIsIHJkKTsKPiArICAgICAgICAgICAgcyA9IGluY29tcGxldGUgKyBjdXJyZW50X3BvczsK ClRoaXMgY2FuIGJlIGRyb3BwZWQsIGJlY2F1c2UgcyBpcyBub3QgY2hhbmdlZC4gSXQgaXMganVz dCB0aGUgcmV2ZXJzYWwKb2Ygd2hhdCBpcyBhIGZldyBsaW5lcyBhYm92ZS4KCj4gKyAgICAgICAg ICAgIGluY29tcGxldGVfc2l6ZSArPSByZDsKPiArICAgICAgICAgICAgc19lbmQgPSBpbmNvbXBs ZXRlICsgaW5jb21wbGV0ZV9zaXplOwo+ICsgICAgICAgIH0gZWxzZSB7Cj4gKyAgICAgICAgICAg IGluY29tcGxldGUgPSBsaWJ4bF9fc3RybmR1cChnYywgcW1wLT5idWZmZXIsIHJkKTsKPiArICAg ICAgICAgICAgaW5jb21wbGV0ZV9zaXplID0gcmQ7Cj4gKyAgICAgICAgICAgIHMgPSBpbmNvbXBs ZXRlOwo+ICsgICAgICAgICAgICBzX2VuZCA9IHMgKyByZDsKPiArICAgICAgICAgICAgcmQgPSAw OwoKVGhpcyBjYW4gYmUgZHJvcHBlZC4KCkFuZCBJIHRoaW5rIHdlIHNob3VsZCB0YWtlIHRoaXMg Y2hhbmdlIHRvIGNoYW5nZSAiaW5jb21wbGV0ZSIgdG8Kc29tZXRoaW5nIG1vcmUgbWVhbmluZ2Z1 bCwgbGlrZSAicW1wX21zZ19idWYiLgoKPiArICAgICAgICB9Cj4gKwo+ICAgICAgICAgIGRvIHsK PiAgICAgICAgICAgICAgY2hhciAqZW5kID0gTlVMTDsKPiAtICAgICAgICAgICAgaWYgKGluY29t cGxldGUpIHsKPiAtICAgICAgICAgICAgICAgIHNpemVfdCBjdXJyZW50X3BvcyA9IHMgLSBpbmNv bXBsZXRlOwo+IC0gICAgICAgICAgICAgICAgaW5jb21wbGV0ZSA9IGxpYnhsX19yZWFsbG9jKGdj LCBpbmNvbXBsZXRlLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGluY29tcGxldGVfc2l6ZSArIHJkICsgMSk7Cj4gLSAgICAgICAgICAgICAgICBzdHJuY2F0 KGluY29tcGxldGUgKyBpbmNvbXBsZXRlX3NpemUsIHFtcC0+YnVmZmVyLCByZCk7Cj4gLSAgICAg ICAgICAgICAgICBzID0gaW5jb21wbGV0ZSArIGN1cnJlbnRfcG9zOwo+IC0gICAgICAgICAgICAg ICAgaW5jb21wbGV0ZV9zaXplICs9IHJkOwo+IC0gICAgICAgICAgICAgICAgc19lbmQgPSBpbmNv bXBsZXRlICsgaW5jb21wbGV0ZV9zaXplOwo+IC0gICAgICAgICAgICB9IGVsc2Ugewo+IC0gICAg ICAgICAgICAgICAgaW5jb21wbGV0ZSA9IGxpYnhsX19zdHJuZHVwKGdjLCBxbXAtPmJ1ZmZlciwg cmQpOwo+IC0gICAgICAgICAgICAgICAgaW5jb21wbGV0ZV9zaXplID0gcmQ7Cj4gLSAgICAgICAg ICAgICAgICBzID0gaW5jb21wbGV0ZTsKPiAtICAgICAgICAgICAgICAgIHNfZW5kID0gcyArIHJk Owo+IC0gICAgICAgICAgICAgICAgcmQgPSAwOwo+IC0gICAgICAgICAgICB9Cj4gIAo+ICAgICAg ICAgICAgICBlbmQgPSBzdHJzdHIocywgIlxyXG4iKTsKPiAgICAgICAgICAgICAgaWYgKGVuZCkg ewo+IC0tIAo+IEFudGhvbnkgUEVSQVJECj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8veGVuLWRldmVs