From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190AbeDWNHX (ORCPT ); Mon, 23 Apr 2018 09:07:23 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:44534 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754940AbeDWNHU (ORCPT ); Mon, 23 Apr 2018 09:07:20 -0400 X-Google-Smtp-Source: AIpwx4/nT1SvAIx2ad4ZH6JOuPxxWtWM45dLk474DDEy5yy616IVedy83mQMzchv7FYn+0WVZS9PNw== Date: Mon, 23 Apr 2018 15:07:15 +0200 From: Juri Lelli To: Waiman Long Cc: Tejun Heo , Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, Mike Galbraith , torvalds@linux-foundation.org, Roman Gushchin Subject: Re: [PATCH v7 0/5] cpuset: Enable cpuset controller in default hierarchy Message-ID: <20180423130715.GA32341@localhost.localdomain> References: <1524145624-23655-1-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1524145624-23655-1-git-send-email-longman@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Waiman, On 19/04/18 09:46, Waiman Long wrote: > v7: > - Add a root-only cpuset.cpus.isolated control file for CPU isolation. > - Enforce that load_balancing can only be turned off on cpusets with > CPUs from the isolated list. > - Update sched domain generation to allow cpusets with CPUs only > from the isolated CPU list to be in separate root domains. Just got this while # echo 2-3 > /sys/fs/cgroup/cpuset.cpus.isolated [ 6679.177826] ============================= [ 6679.178385] WARNING: suspicious RCU usage [ 6679.178910] 4.16.0-rc6+ #151 Not tainted [ 6679.179459] ----------------------------- [ 6679.180082] /home/juri/work/kernel/linux/kernel/cgroup/cgroup.c:3826 cgroup_mutex or RCU read lock required! [ 6679.181402] [ 6679.181402] other info that might help us debug this: [ 6679.181402] [ 6679.182407] [ 6679.182407] rcu_scheduler_active = 2, debug_locks = 1 [ 6679.183278] 3 locks held by bash/2205: [ 6679.183785] #0: (sb_writers#10){.+.+}, at: [<000000004e577fb9>] vfs_write+0x18a/0x1b0 [ 6679.184871] #1: (&of->mutex){+.+.}, at: [<000000005944c83f>] kernfs_fop_write+0xe2/0x1a0 [ 6679.185987] #2: (cpuset_mutex){+.+.}, at: [<00000000879bfba0>] cpuset_write_resmask+0x72/0x1560 [ 6679.187112] [ 6679.187112] stack backtrace: [ 6679.187612] CPU: 3 PID: 2205 Comm: bash Not tainted 4.16.0-rc6+ #151 [ 6679.188318] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-2.fc27 04/01/2014 [ 6679.189291] Call Trace: [ 6679.189581] dump_stack+0x85/0xc5 [ 6679.189963] css_next_child+0x90/0xd0 [ 6679.190385] cpuset_write_resmask+0x46f/0x1560 [ 6679.190885] ? lock_acquire+0x9f/0x210 [ 6679.191315] cgroup_file_write+0x94/0x230 [ 6679.191768] kernfs_fop_write+0x113/0x1a0 [ 6679.192223] __vfs_write+0x36/0x180 [ 6679.192617] ? rcu_read_lock_sched_held+0x6b/0x80 [ 6679.193139] ? rcu_sync_lockdep_assert+0x2e/0x60 [ 6679.193654] ? __sb_start_write+0x154/0x1f0 [ 6679.194118] ? __sb_start_write+0x16a/0x1f0 [ 6679.194607] vfs_write+0xc1/0x1b0 [ 6679.194984] SyS_write+0x55/0xc0 [ 6679.195365] ? trace_hardirqs_off_thunk+0x1a/0x1c [ 6679.195839] do_syscall_64+0x79/0x220 [ 6679.196212] entry_SYSCALL_64_after_hwframe+0x42/0xb7 [ 6679.196729] RIP: 0033:0x7f03183ff780 [ 6679.197138] RSP: 002b:00007ffeae336ca8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 6679.197866] RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007f03183ff780 [ 6679.198550] RDX: 0000000000000004 RSI: 0000000000eaf408 RDI: 0000000000000001 [ 6679.199235] RBP: 0000000000eaf408 R08: 000000000000000a R09: 00007f0318cff700 [ 6679.199928] R10: 0000000000000000 R11: 0000000000000246 R12: 00007f03186b57a0 [ 6679.200615] R13: 0000000000000004 R14: 0000000000000001 R15: 0000000000000000 [ 6679.201369] rebuild_sched_domains dom 0: 0-1 [ 6679.202196] span: 0-1 (max cpu_capacity = 1024) Guess we should grab either lock from the writing path. Best, - Juri From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id ACB6B7E677 for ; Mon, 23 Apr 2018 13:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754994AbeDWNHW (ORCPT ); Mon, 23 Apr 2018 09:07:22 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:40106 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754922AbeDWNHU (ORCPT ); Mon, 23 Apr 2018 09:07:20 -0400 Received: by mail-wr0-f194.google.com with SMTP id v60-v6so41077434wrc.7 for ; Mon, 23 Apr 2018 06:07:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0zhqAmGX41MQSuPc+qGdCAXtCmDpz4Ff0+nNX5+8584=; b=lfzLUj9Fg3+W51bRKYcUwIIDqh3jdP/hm072pSHNq4cWalLdmba47Lxo7LzPZ1WGrp +ScCYCFcDVqyYdaCzyj9xC41QffHgZngyNs8R247JUZFQ8loh36ZTwfZ8NofZRHLYHD3 gnCb42BXzgHiQm4494fvEjrQAgfAGpQ2evwexkj4n9Kxq5y3d6HZmSczq0vm4oEdJYc3 zrmVxxgd3ATqxG0W6i7BBSfomXXRXC9gWhnNtKCW37oeb8I0u2KbLCTY4ArwXe71pVKi KPs0qcmzT86hycaf6l1HQrQUpK4oQKGVgPsQ6+nvOPFXpz69YqOtYa3b0eauj0YeeBpT Gi2Q== X-Gm-Message-State: ALQs6tD4GcTj1hxFfM/TGCEjKoh60NfrU6ELcgPkrKiSMD/i2tY/0hKE DXHf9X5rIIn2JM4MbEPF89oGJg== X-Google-Smtp-Source: AIpwx4/nT1SvAIx2ad4ZH6JOuPxxWtWM45dLk474DDEy5yy616IVedy83mQMzchv7FYn+0WVZS9PNw== X-Received: by 10.28.190.15 with SMTP id o15mr6319242wmf.104.1524488839050; Mon, 23 Apr 2018 06:07:19 -0700 (PDT) Received: from localhost.localdomain ([151.15.228.118]) by smtp.gmail.com with ESMTPSA id w14sm8809067wmd.1.2018.04.23.06.07.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 06:07:18 -0700 (PDT) Date: Mon, 23 Apr 2018 15:07:15 +0200 From: Juri Lelli To: Waiman Long Cc: Tejun Heo , Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, Mike Galbraith , torvalds@linux-foundation.org, Roman Gushchin Subject: Re: [PATCH v7 0/5] cpuset: Enable cpuset controller in default hierarchy Message-ID: <20180423130715.GA32341@localhost.localdomain> References: <1524145624-23655-1-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1524145624-23655-1-git-send-email-longman@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Waiman, On 19/04/18 09:46, Waiman Long wrote: > v7: > - Add a root-only cpuset.cpus.isolated control file for CPU isolation. > - Enforce that load_balancing can only be turned off on cpusets with > CPUs from the isolated list. > - Update sched domain generation to allow cpusets with CPUs only > from the isolated CPU list to be in separate root domains. Just got this while # echo 2-3 > /sys/fs/cgroup/cpuset.cpus.isolated [ 6679.177826] ============================= [ 6679.178385] WARNING: suspicious RCU usage [ 6679.178910] 4.16.0-rc6+ #151 Not tainted [ 6679.179459] ----------------------------- [ 6679.180082] /home/juri/work/kernel/linux/kernel/cgroup/cgroup.c:3826 cgroup_mutex or RCU read lock required! [ 6679.181402] [ 6679.181402] other info that might help us debug this: [ 6679.181402] [ 6679.182407] [ 6679.182407] rcu_scheduler_active = 2, debug_locks = 1 [ 6679.183278] 3 locks held by bash/2205: [ 6679.183785] #0: (sb_writers#10){.+.+}, at: [<000000004e577fb9>] vfs_write+0x18a/0x1b0 [ 6679.184871] #1: (&of->mutex){+.+.}, at: [<000000005944c83f>] kernfs_fop_write+0xe2/0x1a0 [ 6679.185987] #2: (cpuset_mutex){+.+.}, at: [<00000000879bfba0>] cpuset_write_resmask+0x72/0x1560 [ 6679.187112] [ 6679.187112] stack backtrace: [ 6679.187612] CPU: 3 PID: 2205 Comm: bash Not tainted 4.16.0-rc6+ #151 [ 6679.188318] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-2.fc27 04/01/2014 [ 6679.189291] Call Trace: [ 6679.189581] dump_stack+0x85/0xc5 [ 6679.189963] css_next_child+0x90/0xd0 [ 6679.190385] cpuset_write_resmask+0x46f/0x1560 [ 6679.190885] ? lock_acquire+0x9f/0x210 [ 6679.191315] cgroup_file_write+0x94/0x230 [ 6679.191768] kernfs_fop_write+0x113/0x1a0 [ 6679.192223] __vfs_write+0x36/0x180 [ 6679.192617] ? rcu_read_lock_sched_held+0x6b/0x80 [ 6679.193139] ? rcu_sync_lockdep_assert+0x2e/0x60 [ 6679.193654] ? __sb_start_write+0x154/0x1f0 [ 6679.194118] ? __sb_start_write+0x16a/0x1f0 [ 6679.194607] vfs_write+0xc1/0x1b0 [ 6679.194984] SyS_write+0x55/0xc0 [ 6679.195365] ? trace_hardirqs_off_thunk+0x1a/0x1c [ 6679.195839] do_syscall_64+0x79/0x220 [ 6679.196212] entry_SYSCALL_64_after_hwframe+0x42/0xb7 [ 6679.196729] RIP: 0033:0x7f03183ff780 [ 6679.197138] RSP: 002b:00007ffeae336ca8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 6679.197866] RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007f03183ff780 [ 6679.198550] RDX: 0000000000000004 RSI: 0000000000eaf408 RDI: 0000000000000001 [ 6679.199235] RBP: 0000000000eaf408 R08: 000000000000000a R09: 00007f0318cff700 [ 6679.199928] R10: 0000000000000000 R11: 0000000000000246 R12: 00007f03186b57a0 [ 6679.200615] R13: 0000000000000004 R14: 0000000000000001 R15: 0000000000000000 [ 6679.201369] rebuild_sched_domains dom 0: 0-1 [ 6679.202196] span: 0-1 (max cpu_capacity = 1024) Guess we should grab either lock from the writing path. Best, - Juri -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html