From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755909AbeDWP0D (ORCPT ); Mon, 23 Apr 2018 11:26:03 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33332 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755666AbeDWP0B (ORCPT ); Mon, 23 Apr 2018 11:26:01 -0400 Date: Mon, 23 Apr 2018 18:25:57 +0300 From: "Michael S. Tsirkin" To: Mikulas Patocka Cc: Matthew Wilcox , David Miller , Andrew Morton , linux-mm@kvack.org, eric.dumazet@gmail.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jasowang@redhat.com, virtualization@lists.linux-foundation.org, dm-devel@redhat.com, Vlastimil Babka Subject: Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM Message-ID: <20180423181250-mutt-send-email-mst@kernel.org> References: <3e65977e-53cd-bf09-bc4b-0ce40e9091fe@gmail.com> <20180418.134651.2225112489265654270.davem@davemloft.net> <20180420114712.GB10788@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 20, 2018 at 08:20:23AM -0400, Mikulas Patocka wrote: > > > On Fri, 20 Apr 2018, Matthew Wilcox wrote: > > > On Thu, Apr 19, 2018 at 12:12:38PM -0400, Mikulas Patocka wrote: > > > Unfortunatelly, some kernel code has bugs - it uses kvmalloc and then > > > uses DMA-API on the returned memory or frees it with kfree. Such bugs were > > > found in the virtio-net driver, dm-integrity or RHEL7 powerpc-specific > > > code. > > > > Maybe it's time to have the SG code handle vmalloced pages? This is > > becoming more and more common with vmapped stacks (and some of our > > workarounds are hideous -- allocate 4 bytes with kmalloc because we can't > > DMA onto the stack any more?). We already have a few places which do > > handle sgs of vmalloced addresses, such as the nx crypto driver: > > > > if (is_vmalloc_addr(start_addr)) > > sg_addr = page_to_phys(vmalloc_to_page(start_addr)) > > + offset_in_page(sg_addr); > > else > > sg_addr = __pa(sg_addr); > > > > and videobuf: > > > > pg = vmalloc_to_page(virt); > > if (NULL == pg) > > goto err; > > BUG_ON(page_to_pfn(pg) >= (1 << (32 - PAGE_SHIFT))); > > sg_set_page(&sglist[i], pg, PAGE_SIZE, 0); > > > > Yes, there's the potential that we have to produce two SG entries for a > > virtually contiguous region if it crosses a page boundary, and our APIs > > aren't set up right to make it happen. But this is something we should > > consider fixing ... otherwise we'll end up with dozens of driver hacks. > > The videobuf implementation was already copy-and-pasted into the saa7146 > > driver, for example. > > What if the device requires physically contiguous area and the vmalloc > area crosses a page? Will you use a bounce buffer? Where do you allocate > the bounce buffer from? What if you run out of bounce buffers? > > Mikulkas I agree with Matthew here. 4 byte variables are typically size aligned so won't cross a boundary. That's enough for virtio at least. People using structs can force alignment. We could wrap access in a macro (sizeof(x) >= alignof(x)) to help guarantee that. -- MST