From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC v3 net-next 13/18] net/sched: Introduce the TBS Qdisc Date: Tue, 24 Apr 2018 09:50:48 -0400 (EDT) Message-ID: <20180424.095048.818224012961344954.davem@davemloft.net> References: <768e8da5-502e-d36f-0f32-9324eaca4a1d@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jesus.sanchez-palencia@intel.com, netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, vinicius.gomes@intel.com, richardcochran@gmail.com, intel-wired-lan@lists.osuosl.org, anna-maria@linutronix.de, henrik@austad.us, john.stultz@linaro.org, levi.pearson@harman.com, edumazet@google.com, willemb@google.com, mlichvar@redhat.com To: tglx@linutronix.de Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:34366 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758222AbeDXNuv (ORCPT ); Tue, 24 Apr 2018 09:50:51 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Thomas Gleixner Date: Tue, 24 Apr 2018 10:50:04 +0200 (CEST) > So adding 8 bytes to spare duplicated code will not change the kmem_cache > object size and I really doubt that anyone will notice. It's about where the cache lines end up when each and every byte is added to the structure, not just the slab object size. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Tue, 24 Apr 2018 09:50:48 -0400 (EDT) Subject: [Intel-wired-lan] [RFC v3 net-next 13/18] net/sched: Introduce the TBS Qdisc In-Reply-To: References: <768e8da5-502e-d36f-0f32-9324eaca4a1d@intel.com> Message-ID: <20180424.095048.818224012961344954.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: From: Thomas Gleixner Date: Tue, 24 Apr 2018 10:50:04 +0200 (CEST) > So adding 8 bytes to spare duplicated code will not change the kmem_cache > object size and I really doubt that anyone will notice. It's about where the cache lines end up when each and every byte is added to the structure, not just the slab object size.