All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: luc.vanoostenryck@gmail.com
Cc: linux-kernel@vger.kernel.org, igor.russkikh@aquantia.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: aquantia: fix aq_ndev_start_xmit()'s return type
Date: Tue, 24 Apr 2018 10:42:50 -0400 (EDT)	[thread overview]
Message-ID: <20180424.104250.1411072442966778574.davem@davemloft.net> (raw)
In-Reply-To: <20180424131623.3505-1-luc.vanoostenryck@gmail.com>


Luc please don't submit such a huge number of patches all at one time.

Also, please fix the indentation of the functions whose arguments
span multiple lines as has been pointed out to you in patch feedback.

Finally, make this a true patch series.  It is so much easier for
maintainers to work with a set of changes all doing the same thing if
you make them a proper patch series with an appropriate "[PATCH 0/N] ..."
header posting.

Thank you.

  reply	other threads:[~2018-04-24 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 13:16 [PATCH] net: aquantia: fix aq_ndev_start_xmit()'s return type Luc Van Oostenryck
2018-04-24 14:42 ` David Miller [this message]
2018-04-26 20:37   ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424.104250.1411072442966778574.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=igor.russkikh@aquantia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.