From: Gerd Hoffmann <kraxel@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, kwankhede@nvidia.com,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] sample: vfio mdev display - host device
Date: Tue, 24 Apr 2018 08:29:19 +0200 [thread overview]
Message-ID: <20180424062919.bouvw7qxyrvi3vqc@sirius.home.kraxel.org> (raw)
In-Reply-To: <20180423204139.2d157869@w520.home>
Hi,
> > +/* pci ids */
> > +#define MDPY_PCI_VENDOR_ID 0x1b36 /* redhat */
> > +#define MDPY_PCI_DEVICE_ID 0x00f0
>
> I don't see this on pci-ids, so I assume we're just squatting on an
> ID. How do we do that without risking that we don't interfere with
> some future user? Are we relying on this being a non-default sample
> device? Should we just ask for an allocation?
It's grabbed from qemu id range.
Allocating one is probably a good idea even for a sample device.
> > +#define MDPY_PCI_SUBVENDOR_ID PCI_SUBVENDOR_ID_REDHAT_QUMRANET
> > +#define MDPY_PCI_SUBDEVICE_ID PCI_SUBDEVICE_ID_QEMU
> > +
> > +/* pci cfg space offsets for fb config (dword) */
> > +#define MDPY_FORMAT_OFFSET 0x40
> > +#define MDPY_WIDTH_OFFSET 0x44
> > +#define MDPY_HEIGHT_OFFSET 0x48
>
> As I understand, these are just registers in PCI config space outside
> of any capabilities. Wouldn't it be more correct to put these within a
> vendor defined capability?
Can do that.
> > + region_info->size = mdev_state->memsize;
> > + region_info->flags = (VFIO_REGION_INFO_FLAG_READ |
> > + VFIO_REGION_INFO_FLAG_WRITE |
> > + VFIO_REGION_INFO_FLAG_MMAP);
>
> This doesn't appear to be true, the read and write functions call the
> access function which only handles the config space region. Are these
> really mmap-only regions?
Yes, they are mmap-only.
> read/write access support is often useful
> for tracing and debugging, QEMU will break if x-no-mmap=on is used.
Hmm, can look into adding that, should not be that difficuilt after all.
cheers,
Gerd
next prev parent reply other threads:[~2018-04-24 6:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180409103513.8020-1-kraxel@redhat.com>
2018-04-09 10:35 ` [PATCH 1/3] sample: vfio mdev display - host device Gerd Hoffmann
2018-04-24 2:41 ` Alex Williamson
2018-04-24 6:29 ` Gerd Hoffmann [this message]
2018-04-09 10:35 ` [PATCH 2/3] sample: vfio mdev display - guest driver Gerd Hoffmann
2018-04-11 20:39 ` Bjorn Helgaas
2018-04-24 2:51 ` Alex Williamson
2018-04-25 21:03 ` Konrad Rzeszutek Wilk
2018-04-09 10:35 ` [PATCH 3/3] sample: vfio bochs vbe display (host device for bochs-drm) Gerd Hoffmann
2018-04-24 3:05 ` Alex Williamson
2018-04-18 18:31 ` [libvirt] [PATCH 0/3] sample: vfio mdev display devices Alex Williamson
2018-04-19 8:40 ` Gerd Hoffmann
2018-04-19 10:03 ` Zhenyu Wang
2018-04-19 14:20 ` Alex Williamson
2018-04-19 14:54 ` Paolo Bonzini
2018-04-23 21:40 ` Alex Williamson
2018-04-24 7:17 ` Gerd Hoffmann
2018-04-24 17:35 ` Alex Williamson
2018-04-25 9:49 ` Zhang, Tina
2018-04-24 19:50 ` Kirti Wankhede
2018-04-24 22:59 ` Alex Williamson
2018-04-25 15:30 ` Kirti Wankhede
2018-04-25 18:00 ` Alex Williamson
2018-04-25 19:52 ` Dr. David Alan Gilbert
2018-04-26 18:45 ` Kirti Wankhede
2018-04-26 18:55 ` Dr. David Alan Gilbert
2018-04-27 17:21 ` Alex Williamson
2018-05-03 18:58 ` [libvirt] Expose vfio device display/migration to libvirt and above, was " Alex Williamson
2018-05-04 7:49 ` Erik Skultety
2018-05-04 16:03 ` Alex Williamson
2018-05-07 6:25 ` Gerd Hoffmann
2018-07-20 4:56 ` Yuan, Hang
2018-08-08 7:43 ` Gerd Hoffmann
2018-05-10 11:00 ` Erik Skultety
2018-05-10 15:57 ` Alex Williamson
2018-05-04 9:16 ` Daniel P. Berrangé
2018-05-04 17:06 ` Alex Williamson
2018-05-07 6:15 ` Gerd Hoffmann
2018-05-04 8:39 ` [libvirt] " Erik Skultety
2018-04-26 3:44 ` Tian, Kevin
2018-04-26 6:14 ` Gerd Hoffmann
2018-04-26 15:44 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424062919.bouvw7qxyrvi3vqc@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.